Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.x] Fix ButtonGroup not showing active state if value are numbers #10916

Open
wants to merge 8 commits into
base: 5.x
Choose a base branch
from
Open

[5.x] Fix ButtonGroup not showing active state if value are numbers #10916

wants to merge 8 commits into from

Commits on Oct 8, 2024

  1. Fix handling number keys in fieldtypes using HasSelectOptions 

    Due to a change in 0b85403 the
ButtonGroup fieldtype cannot display a button as active, if the
key is a number.

This commit will
- make the ButtonGroup fieldtype work with number keys again
- make the Width fieldtype work again, if the default options have been
  changed by the user, because changing the prefilled list will result
  in a mix of strings and integers
- output labels consistently as strings
    @morhi
    morhi committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    fe1465c View commit details
    Browse the repository at this point in the history

  2. Fix lint

    @morhi
    morhi committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    5ed065b View commit details
    Browse the repository at this point in the history

  3. Fix test and restore previous behaviour

    @morhi
    morhi committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    633e384 View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2024

  1. Remove ButtonGroup strict comparison, but ensure same for change even… 

    …t as value type
    @morhi
    morhi committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    0354bfb View commit details
    Browse the repository at this point in the history

  2. Revert strict comparison in WidthSelector

    @morhi
    morhi committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    ed47283 View commit details
    Browse the repository at this point in the history

  3. Revert string cast from select option labels

    @morhi
    morhi committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    b987cc9 View commit details
    Browse the repository at this point in the history

  4. Revert blank line change

    @morhi
    morhi committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    f7e26d4 View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2024

  1. Merge branch '5.x' into fix-button-group-integer-handling

    @morhi
    morhi authored Nov 13, 2024
    Configuration menu
    Copy the full SHA
    78b46f0 View commit details
    Browse the repository at this point in the history