[5.x] Add --clear
option for starter-kit:export
#11079
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
--clear
option forstarter-kit:export
command.We talked about whether or not to make this the default behaviour, but it gets complicated for various reasons...
Say you intentionally have
.github
directory in your starter kit repo, but also different.github
directory in your sandbox/demo app repo, you wouldn't want to add this to yourexport_paths
, but you also wouldn't want--clear
to clear this stuff.Or maybe you want to make changes to the stubbed composer.json, should
--clear
also clear that file?etc.
We could find ways to make this behaviour more magical, but we opted to go with a simple opt-in
--clear
option.When explicitly exporting with this option, the starter kit dev knows that it's going to clear everything out first, and then they can discard whatever overzealously cleared git changes they don't want before commiting 👍
It's more
--clear
this way 😎