Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.x] Add --clear option for starter-kit:export #11079

Merged
merged 4 commits into from
Nov 6, 2024

Conversation

jesseleite
Copy link
Member

This PR adds --clear option for starter-kit:export command.

We talked about whether or not to make this the default behaviour, but it gets complicated for various reasons...

  • Say you intentionally have .github directory in your starter kit repo, but also different .github directory in your sandbox/demo app repo, you wouldn't want to add this to your export_paths, but you also wouldn't want --clear to clear this stuff.

  • Or maybe you want to make changes to the stubbed composer.json, should --clear also clear that file?

  • etc.

We could find ways to make this behaviour more magical, but we opted to go with a simple opt-in --clear option.

When explicitly exporting with this option, the starter kit dev knows that it's going to clear everything out first, and then they can discard whatever overzealously cleared git changes they don't want before commiting 👍

It's more --clear this way 😎

@jesseleite jesseleite force-pushed the starter-kit-export-clear-option branch from 25fa720 to 7180d77 Compare November 6, 2024 20:33
@jasonvarga jasonvarga merged commit 16bb315 into 5.x Nov 6, 2024
17 checks passed
@jasonvarga jasonvarga deleted the starter-kit-export-clear-option branch November 6, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants