Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.x] Add folder based starter kit modules #11104

Draft
wants to merge 18 commits into
base: 5.x
Choose a base branch
from
Draft

[5.x] Add folder based starter kit modules #11104

wants to merge 18 commits into from

Commits on Nov 9, 2024

  1. Use dot notation in module keys so we can use Arr::dot() etc.

    @jesseleite
    jesseleite committed Nov 9, 2024
    Configuration menu
    Copy the full SHA
    e2183db View commit details
    Browse the repository at this point in the history

  2. Allow default param on config() helper.

    @jesseleite
    jesseleite committed Nov 9, 2024
    Configuration menu
    Copy the full SHA
    d69a43b View commit details
    Browse the repository at this point in the history

  3. Add setChildModules() helper, so that we can override children afte… 

    …r prompting.
    @jesseleite
    jesseleite committed Nov 9, 2024
    Configuration menu
    Copy the full SHA
    9588e0b View commit details
    Browse the repository at this point in the history

  4. Separate out instantiation and prompting logic.

    @jesseleite
    jesseleite committed Nov 9, 2024
    Configuration menu
    Copy the full SHA
    8a15e7b View commit details
    Browse the repository at this point in the history

  5. Flatten modules before installing.

    @jesseleite
    jesseleite committed Nov 9, 2024
    Configuration menu
    Copy the full SHA
    6a6d86a View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2024

  1. Rename method.

    @jesseleite
    jesseleite committed Nov 10, 2024
    Configuration menu
    Copy the full SHA
    833e463 View commit details
    Browse the repository at this point in the history

  2. Test import syntax recursively imports from /modules folders.

    @jesseleite
    jesseleite committed Nov 10, 2024
    Configuration menu
    Copy the full SHA
    04e80f6 View commit details
    Browse the repository at this point in the history

  3. Module import implementation.

    @jesseleite
    jesseleite committed Nov 10, 2024
    Configuration menu
    Copy the full SHA
    3fa6bcf View commit details
    Browse the repository at this point in the history

  4. Add test coverage for error handling.

    @jesseleite
    jesseleite committed Nov 10, 2024
    Configuration menu
    Copy the full SHA
    ee5f969 View commit details
    Browse the repository at this point in the history

  5. Extract module instantiation and flattening to helper class for John.

    @jesseleite
    jesseleite committed Nov 10, 2024
    Configuration menu
    Copy the full SHA
    b9d96ea View commit details
    Browse the repository at this point in the history

  6. Make into a more generic config setter.

    @jesseleite
    jesseleite committed Nov 10, 2024
    Configuration menu
    Copy the full SHA
    bb52694 View commit details
    Browse the repository at this point in the history

  7. Use helper method.

    @jesseleite
    jesseleite committed Nov 10, 2024
    Configuration menu
    Copy the full SHA
    d8641c5 View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2024

  1. Update to match docs PR.

    @jesseleite
    jesseleite committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    3e71b18 View commit details
    Browse the repository at this point in the history

  2. Import merging.

    @jesseleite
    jesseleite committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    889d6db View commit details
    Browse the repository at this point in the history

  3. Fix and properly implement module folder scoping.

    @jesseleite
    jesseleite committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    a0b42b1 View commit details
    Browse the repository at this point in the history

  4. Make this public for John.

    @jesseleite
    jesseleite committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    cc89b46 View commit details
    Browse the repository at this point in the history

  5. Export whole modules folder.

    @jesseleite
    jesseleite committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    37b10c2 View commit details
    Browse the repository at this point in the history

  6. Remove import: ‘@config’ syntax, and implicitly import instead.

    @jesseleite
    jesseleite committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    5ded91e View commit details
    Browse the repository at this point in the history