[5.x] Ensure file cacher honors allow/disallow query string configs #11143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Was meant to link to #11142 - and closed cause we realised it was done for a reason. Chatted to Duncan and this could still work but it would mean Nginx/Apache wouldnt get the HTML directly but it would be served by Statamic - so still faster, but not quite full cache fast. Anyway, I closed it cause of what Jason said in his original PR comments |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the file cacher to respect the allow/disallow query string params.
As it was using its own getUrl() function these were being ignored.
I cant think of any reason why they should be... maybe I'm missing something.
Closes #11143