Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.x] Slight adjustments to the search index table #11171

Open
wants to merge 7 commits into
base: 5.x
Choose a base branch
from

Conversation

daun
Copy link
Contributor

@daun daun commented Nov 26, 2024

Spent a lot of time in the search index screen recently and found a few little spots to optimize :)

  • Make sure the icons aren't squished when the other columns grow
  • Add an icon for unknown/custom drivers
  • Add an icon for the Loupe search engine
  • Make sure everything is top-aligned

Drive-by changes

  • Setting a fallback unknown/custom driver icon required updating the svg helper to optionally pass in a fallback icon in case the requested one doesn't exist. Might be useful in other future use case as well?

Before

Screenshot 2024-11-26 at 10 48 16

After

Screenshot 2024-11-26 at 11 00 19

Signed-off-by: Philipp Daun <post@philippdaun.net>
Signed-off-by: Philipp Daun <post@philippdaun.net>
Signed-off-by: Philipp Daun <post@philippdaun.net>
Signed-off-by: Philipp Daun <post@philippdaun.net>
Signed-off-by: Philipp Daun <post@philippdaun.net>
Signed-off-by: Philipp Daun <post@philippdaun.net>
Signed-off-by: Philipp Daun <post@philippdaun.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant