Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add folder_iam field to Atlantis config #19

Merged
merged 4 commits into from
Apr 23, 2024
Merged

Conversation

nicolst
Copy link
Contributor

@nicolst nicolst commented Apr 22, 2024

Add a folder_iam field to the atlantis config, so we can grant arbitrary roles on folders to each atlantis.

Usage:

atlantis:
  folder_iam:
    - folder: "123456"
      role: roles/rolename

Implemented as a list of objects instead of a map of folder names to lists of roles, because jsonschema is ...................

NOTE: there are project_iam and bucket_iam fields in use in the atlantis block today which are not in the schema, probably because the validation action wasn't added at the time.

@nicolst nicolst requested a review from a team as a code owner April 22, 2024 21:38
@github-actions github-actions bot added enhancement New feature or request java Updates to the generated Java project json-schema Updates to the source models labels Apr 22, 2024
@nicolst nicolst changed the title feat(kuben-team): add folder_iam field to atlantis config Add folder_iam field to Atlantis config Apr 22, 2024
@nicolst nicolst added the minor label Apr 22, 2024
Copy link
Member

@johnksv johnksv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This make sense.
You mentioned project_iam and bucket_iam which are in use today(?). Should these be added to the schema as well to reflect the correct options. Either in this PR or another

@nicolst
Copy link
Contributor Author

nicolst commented Apr 23, 2024

Perhaps, but the problem is that they are maps of strings to list of strings... Which we apparently can't make work in jsonschema. But maybe we could convert the existing use to lists of objects

@nicolst nicolst merged commit 20c7bf5 into main Apr 23, 2024
2 checks passed
@nicolst nicolst deleted the feat/add-atlantis-folder-iam branch April 23, 2024 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request java Updates to the generated Java project json-schema Updates to the source models minor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants