Usability and Mac improvements #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds an exit() overload and a library destructor routine that call libc_sync() when syncs have been eaten and the EATMYDATA_END_SYNC env. var is set. They also print how many syncs were swallowed, if EATMYDATA_VERBOSE is set. Committed from host : Portia.local
Committed from host : Portia.local
let the OS deallocate progName and cache nosyncs before printing, all to prevent race conditions and print something that's less likely to be wrong. Committed from host : Bola
Set EATMYDATA_END_SYNC=1 to sync only when the 1st eatmydata instance exits (libeatmydata reads and unsets the variable internally). Use EATMYDATA_END_SYNC=2 to present the variable and cause an end-sync in each child process. Also, reformat the source. Committed from host : Portia.local
EATMYDATA_END_SYNC=-1 will disable eating syncs after exit() or _exit() have been called, allowing the libc runtime to do any of the explicit syncs it wants to do. A new close() overload also starts doing explicit fsync's on the descriptors it has to close. Potential because I haven't yet seen it do any syncs or NOT eat any. Committed from host : Bola
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the PR announced in issue #13 . It's become a bit of a catch-all for a number of more or less (un)related changes:
EATMYDATA_END_SYNC=1to do this only in the application launched by the user, set itEATMYDATA_END_SYNC=2to do it in every child process too (that does slow things down if the child processes each do only tiny bits of work).EATMYDATA_VERBOSEto print out the number of syncs and sync modes that were swallowed. Uses a simple counter without any thread-safeties because there's nothing crucial to the feature and I don't want to introduce locks in overloads of functions that have to remain signal-safe.And, a bit stupidly: a source code reformat.