Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XY/v1 #597

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

XY/v1 #597

wants to merge 1 commit into from

Conversation

jazsmi
Copy link
Contributor

@jazsmi jazsmi commented Dec 16, 2020

This PR adds documentation for the new X-Y integration.

@jazsmi jazsmi self-assigned this Dec 16, 2020
@@ -0,0 +1,104 @@
---
tap: "x-y"
version: "1.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
version: "1.0"
version: "1"

Comment on lines +14 to +16
api-method:
name: ""
doc-link: ""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know XY doesn't have public docs, so it's fine that this isn't filled out. When this isn't being used, please comment it out. That way it won't create an empty field when Jekyll builds the site.

@@ -0,0 +1,96 @@
---
tap: "x-y"
version: "1.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
version: "1.0"
version: "1"

@@ -0,0 +1,137 @@
---
tap: "x-y"
version: "1.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
version: "1.0"
version: "1"

Comment on lines +9 to +12
description: ""

replication-method: |
The `{{ table.name }}` table contains information about invoices in your {{ integration.display_name }} account.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: ""
replication-method: |
The `{{ table.name }}` table contains information about invoices in your {{ integration.display_name }} account.
description: |
The `{{ table.name }}` table contains information about invoices in your {{ integration.display_name }} account.
replication-method: "Key-based Incremental"

Comment on lines +9 to +12
description: ""

replication-method: |
The `{{ table.name }}` table contains information about items in your {{ integration.display_name }} account.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: ""
replication-method: |
The `{{ table.name }}` table contains information about items in your {{ integration.display_name }} account.
description: |
The `{{ table.name }}` table contains information about items in your {{ integration.display_name }} account.
replication-method: "Key-based Incremental"

@@ -0,0 +1,142 @@
---
tap: "x-y"
version: "1.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
version: "1.0"
version: "1"

---
tap: "x-y"
version: "1.0"
key: "sale"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
key: "sale"
key: "sale-order-line"

Comment on lines +3 to +4
version: "1.0"
key: "stock"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
version: "1.0"
key: "stock"
version: "1"
key: "stock-transfer"

Comment on lines +3 to +4
version: "1.0"
key: "inventory"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
version: "1.0"
key: "inventory"
version: "1"
key: "inventory-movement"

@lmilan lmilan added the on_hold label Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants