Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

variant(wb55): add STeaMi board #2526

Merged
merged 4 commits into from
Oct 28, 2024
Merged

variant(wb55): add STeaMi board #2526

merged 4 commits into from
Oct 28, 2024

Conversation

nedseb
Copy link
Contributor

@nedseb nedseb commented Sep 25, 2024

Add support to the STeaMi board developed for the project I-NOVMICRO with help from ST Rousset.

I tried to follow all the steps of the Wiki. Let me know if something is missing.

@fpistm
Copy link
Member

fpistm commented Sep 26, 2024

Hi @nedseb
Thanks for the PR.
Have you any documentations (User manual, schematics,...) helping to review the PR?

@fpistm fpistm added this to the 2.9.0 milestone Sep 26, 2024
@fpistm fpistm added the new variant Add support of new bard label Sep 26, 2024
@nedseb
Copy link
Contributor Author

nedseb commented Sep 26, 2024 •
edited
Loading

Hi @nedseb Thanks for the PR. Have you any documentations (User manual, schematics,...) helping to review the PR?

Hi @fpistm,
You can find the reference design of the boards here : https://github.com/steamicc/steami-reference-design
I hope it will help you to review this PR. I will extract the pinout into a more human-readable version soon.

nedseb added a commit to nedseb/Arduino_Core_STM32 that referenced this pull request Sep 27, 2024
@nedseb
feat(platform): Add OpenOCD programming support for STeaMi and Nucleo…
8a20dde 
… 64 boards

- Modified `platform.txt` to enable programming via OpenOCD, which was already used for debugging.
- Added an example demonstrating how to program all Nucleo-64 boards, whether they use STLink or DAPLink.

To avoid conflict, the support for STeaMi will be added after the merge of the PR stm32duino#2526

*Benefits:*

- Enables programming of STeaMi boards.
- Supports P_NUCLEO boards that use DAPLink instead of STLink to leverage WebUSB functionality.
@nedseb nedseb mentioned this pull request Sep 27, 2024
Merged
nedseb added a commit to nedseb/Arduino_Core_STM32 that referenced this pull request Sep 27, 2024
@nedseb
feat(platform): Add OpenOCD programming support for STeaMi and Nucleo…
f52cbd8 
… 64 boards

- Modified `platform.txt` to enable programming via OpenOCD, which was already used for debugging.
- Added an example demonstrating how to program all Nucleo-64 boards, whether they use STLink or DAPLink.

To avoid conflict, the support for STeaMi will be added after the merge of the PR stm32duino#2526

*Benefits:*

- Enables programming of STeaMi boards.
- Supports P_NUCLEO boards that use DAPLink instead of STLink to leverage WebUSB functionality.
@nedseb
Copy link
Contributor Author

nedseb commented Oct 1, 2024 •
edited
Loading

I rebased this PR on top of the merge commit of PR #2528.

To be compatible with DAPLink, I need to replace transport select hla_swd with transport select swd (or at least remove it, because the default transport option on DAPLink is SWD).

To achieve this, I changed the default configuration of OpenOCD by modifying the value of debug.server.openocd.scripts.1. Previously, I used the target script to do this, but with the refactoring of the OpenOCD command, I broke (again) the CMake generation step of the CI.

I see 2 options, the first one is to modify the script update_boarddb.py to handle the configuration STeaMi.menu.pnum.STEAM32_WB55RG.debug.server.openocd.scripts.1={runtime.platform.path}/debugger/select_swd.cfg or simply remove this line as the stlink interface configuration seems to don't need it anymore (I tested this option only with my P_NUCLEO).

What do you think about these options ?

fpistm
fpistm reviewed Oct 1, 2024
View reviewed changes
Copy link
Member

@fpistm fpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First round.

variants/STM32WBxx/WB55R(C-E-G)V/variant_STEAM32_WB55RG.h Outdated Show resolved Hide resolved
variants/STM32WBxx/WB55R(C-E-G)V/variant_STEAM32_WB55RG.h Outdated Show resolved Hide resolved
variants/STM32WBxx/WB55R(C-E-G)V/variant_STEAM32_WB55RG.h Outdated Show resolved Hide resolved
variants/STM32WBxx/WB55R(C-E-G)V/variant_STEAM32_WB55RG.h Outdated Show resolved Hide resolved
variants/STM32WBxx/WB55R(C-E-G)V/variant_STEAM32_WB55RG.h Outdated Show resolved Hide resolved
@nedseb @fpistm
variant(wb55): add STeaMi board
272f3fc 
Signed-off-by: Sébastien NEDJAR <sebastien.nedjar@univ-amu.fr>
Co-authored-by: Frederic Pillon <frederic.pillon@st.com>
fpistm
fpistm reviewed Oct 3, 2024
View reviewed changes
Copy link
Member

@fpistm fpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've squashed and rebased on top of the main with some fix and formatting.
Please fetch your repo befopre any further change.

About the GPIO expander definition, I don't think it is a good idea to give them a number.

Finally, for pins not on a connector, you could add a custom peripheral pins to save space.

boards.txt Show resolved Hide resolved
boards.txt Show resolved Hide resolved
variants/STM32WBxx/WB55R(C-E-G)V/variant_STEAM32_WB55RG.h Outdated Show resolved Hide resolved
fpistm added 2 commits October 3, 2024 10:30
@fpistm
chore(cmake): handle openocd config
cc8ca1c 
Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
@fpistm
chore(cmake): update with new board
19be215 
Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
@fpistm
Copy link
Member

fpistm commented Oct 3, 2024

I've made a commit to fix the cmake issue.

fpistm
fpistm approved these changes Oct 28, 2024
View reviewed changes
Copy link
Member

@fpistm fpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fpistm fpistm merged commit c35b8ef into stm32duino:main Oct 28, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpistm fpistm fpistm approved these changes

Assignees
No one assigned
Labels
new variant Add support of new bard
Projects
STM32 core based on ST HAL
Status: Done
Milestone
2.9.0
Development

Successfully merging this pull request may close these issues.
2 participants
@nedseb @fpistm