Merge pull request #13 from stoplightio/fix/style-exist

fix: check array includes only if style is defined
stoplightio · Jul 31, 2019 · cff0310 · cff0310
2 parents 0c2db6e + 337cc9c
commit cff0310
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 1 deletion.
diff --git a/src/oas3/transformers/__tests__/content.test.ts b/src/oas3/transformers/__tests__/content.test.ts
@@ -114,6 +114,24 @@ describe('translateMediaTypeObject', () => {
     };
     expect(testedFunction).toThrowErrorMatchingSnapshot();
   });
+
+  test('given encoding with no style it should not throw an error', () => {
+    const testedFunction = () => {
+      translateMediaTypeObject(
+        {
+          schema: {},
+          examples: { example: { summary: 'multi example' } },
+          encoding: {
+            enc1: {
+              contentType: 'text/plain',
+            },
+          },
+        },
+        'mediaType',
+      );
+    };
+    expect(() => testedFunction()).not.toThrow();
+  });
 });
 
 describe('translateHeaderObject', () => {

diff --git a/src/oas3/transformers/content.ts b/src/oas3/transformers/content.ts
@@ -16,7 +16,7 @@ function translateEncodingPropertyObject(
     HttpParamStyles.DeepObject,
   ];
 
-  if (!acceptableStyles.includes(encodingPropertyObject.style)) {
+  if (encodingPropertyObject.style && !acceptableStyles.includes(encodingPropertyObject.style)) {
     throw new Error(
       `Encoding property style: '${encodingPropertyObject.style}' is incorrect, must be one of: ${acceptableStyles}`,
     );