Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(controllers): adds a section on controllers quorums and limitations #10864

Merged
merged 2 commits into from
Nov 26, 2024
Merged

docs(controllers): adds a section on controllers quorums and limitations #10864

merged 2 commits into from
Nov 26, 2024

Conversation

PaulRMellor
Copy link
Contributor

@PaulRMellor PaulRMellor commented Nov 22, 2024 •
edited
Loading

Documentation

Adds a section to KRaft overview to describe controller quorums and current limitations with static controller quorums.

Checklist

Please go through this checklist and make sure all applicable tasks have been done

  • Write tests
  • Make sure all tests pass
  • Update documentation
  • Check RBAC rights for Kubernetes / OpenShift roles
  • Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally
  • Reference relevant issue(s) and close them after merging
  • Update CHANGELOG.md
  • Supply screenshots for visual changes, such as Grafana dashboards

@PaulRMellor PaulRMellor added this to the 0.45.0 milestone Nov 22, 2024
@PaulRMellor PaulRMellor self-assigned this Nov 22, 2024
mimaison
mimaison approved these changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@mimaison mimaison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I just left a question

scholzj
scholzj reviewed Nov 22, 2024
View reviewed changes
Copy link
Member

@scholzj scholzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I left some comments.

documentation/assemblies/deploying/assembly-kraft-mode.adoc Outdated Show resolved Hide resolved
documentation/assemblies/deploying/assembly-kraft-mode.adoc Outdated Show resolved Hide resolved
documentation/assemblies/deploying/assembly-kraft-mode.adoc Outdated Show resolved Hide resolved
documentation/assemblies/deploying/assembly-kraft-mode.adoc Outdated Show resolved Hide resolved
@PaulRMellor
docs(review): edits to doc from review by MM and JS
b46a4c5 
Signed-off-by: prmellor <pmellor@redhat.com>
@PaulRMellor
Copy link
Contributor Author

Thanks for the comments @mimaison and @scholzj
All addressed. It makes sense to emphasize the limitations being driven by inability to migrate

@scholzj
Copy link
Member

scholzj commented Nov 22, 2024

@PaulRMellor Did you forget to push the changes?

@scholzj scholzj merged commit 06c5b57 into strimzi:main Nov 26, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katheris katheris katheris approved these changes

@ppatierno ppatierno ppatierno approved these changes

@scholzj scholzj scholzj approved these changes

@mimaison mimaison mimaison approved these changes

@showuon showuon Awaiting requested review from showuon

Assignees

@PaulRMellor PaulRMellor

Labels
documentation
Projects
None yet
Milestone
0.45.0
Development

Successfully merging this pull request may close these issues.
5 participants
@PaulRMellor @scholzj @mimaison @ppatierno @katheris