Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ST] Use KafkaAdmin client for checking the configured rack on Kafka node #10869

Merged
merged 2 commits into from
Nov 25, 2024

Conversation

im-konge
Copy link
Member

@im-konge im-konge commented Nov 22, 2024

Type of change

  • Enhancement

Description

This PR adds methods for using the test-clients' admin-client for describing the Kafka nodes -> so we can use it for the RackAwarenessST#testKafkaRackAwareness.
The option to describe the nodes was added in strimzi/test-clients#114, the change is available in the latest images - which are now used in the test. Once we release the test-clients version 0.10.0, we can just remove it.

Fixes #10663

Checklist

  • Make sure all tests pass

…node

Signed-off-by: Lukas Kral <lukywill16@gmail.com>
@im-konge im-konge added this to the 0.45.0 milestone Nov 22, 2024
Signed-off-by: Lukas Kral <lukywill16@gmail.com>
@im-konge
Copy link
Member Author

/azp run regression

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@im-konge im-konge marked this pull request as ready for review November 23, 2024 12:13
@im-konge im-konge requested review from scholzj and a team November 23, 2024 12:13
@im-konge
Copy link
Member Author

/azp run zookeeper-regression

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@see-quick see-quick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks 👍

@im-konge im-konge merged commit 1b275e5 into strimzi:main Nov 25, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rack awareness tests should not rely on the internal files
4 participants