Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Improve the hostname verification docs for NodePort listeners #10880

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

scholzj
Copy link
Member

@scholzj scholzj commented Nov 25, 2024

Type of change

  • Documentation

Description

This PR improves the docs for the TLS hostname verification when using Node Port listener and suggests that one of the alternatives in situations when users know the broker addresses upfront (e.g. on bare-metal with dedicated nodes) is to add the addressed manually to alternativeNames.

Checklist

  • Update documentation

Signed-off-by: Jakub Scholz <www@scholzj.com>
@scholzj scholzj added this to the 0.45.0 milestone Nov 25, 2024
@scholzj scholzj changed the title Improve the hostname verification docs for NodePort listeners [DOC] Improve the hostname verification docs for NodePort listeners Nov 25, 2024
Copy link
Contributor

@PaulRMellor PaulRMellor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update. I left a couple of suggestions around wording.

Co-authored-by: PaulRMellor <47596553+PaulRMellor@users.noreply.github.com>
Signed-off-by: Jakub Scholz <www@scholzj.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants