Merge pull request #14 from stripe/brandur-coerce-number

Support coercion on the "number" type
stripe · Aug 24, 2017 · 84fd20d · 84fd20d
2 parents 82670b0 + 22fce71
commit 84fd20d
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 0 deletions.
diff --git a/param/coercer/coercer.go b/param/coercer/coercer.go
@@ -42,6 +42,13 @@ func CoerceParams(schema *spec.JSONSchema, data map[string]interface{}) {
 					valInt = 0
 				}
 				data[key] = valInt
+
+			case hasType(subSchema, numberType):
+				valFloat, err := strconv.ParseFloat(valStr, 64)
+				if err != nil {
+					valFloat = 0.0
+				}
+				data[key] = valFloat
 			}
 		}
 	}
@@ -57,6 +64,8 @@ const booleanType = "boolean"
 // integerType is the name of the integer type in a JSON schema.
 const integerType = "integer"
 
+const numberType = "number"
+
 func hasType(schema *spec.JSONSchema, targetTypeStr string) bool {
 	for _, typeStr := range schema.Type {
 		if typeStr == targetTypeStr {

diff --git a/param/coercer/coercer_test.go b/param/coercer/coercer_test.go
@@ -31,6 +31,18 @@ func TestCoerceParams_IntegerCoercion(t *testing.T) {
 	assert.Equal(t, 123, data["intkey"])
 }
 
+func TestCoerceParams_NumberCoercion(t *testing.T) {
+	schema := &spec.JSONSchema{Properties: map[string]*spec.JSONSchema{
+		"numberkey": {Type: []string{numberType}},
+	}}
+	data := map[string]interface{}{
+		"numberkey": "123.45",
+	}
+
+	CoerceParams(schema, data)
+	assert.Equal(t, 123.45, data["numberkey"])
+}
+
 func TestCoerceParams_Recursion(t *testing.T) {
 	schema := &spec.JSONSchema{Properties: map[string]*spec.JSONSchema{
 		"mapkey": {Properties: map[string]*spec.JSONSchema{