New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix use with nodejs #705

Merged

jcbrand merged 2 commits into strophe:master from mattblickem-evoluno:fix/use-with-nodejs

Apr 7, 2024

Contributor

mattblickem-evoluno commented Apr 5, 2024 •

edited

Loading

xmldom does not implement querySelector so in nodejs an uncaught error can be triggered by running non-existant querySelector function

importing strophe.js from node_modules in nodejs by default uses the wrong file (src/index.js). The exports directive in package.json helps nodejs import (or require) the right file: https://nodejs.org/docs/latest-v20.x/api/packages.html#conditional-exports

mattblickem-evoluno added 2 commits

April 5, 2024 11:50


          fix: nodejs import/require

f0722e2


          fix: querySelector not implemented by xmldom

1cef53b

jcbrand merged commit fd5916e into strophe:master

1 check passed

Contributor

jcbrand commented Apr 7, 2024

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet