Set esModuleInterop
as default config of parse
#511
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The React namespace is exported as CommonJs. As stated in TypeScript's Doc, we should always enable
esModuleInterop
.Without
esModuleInterop
, example below will produce incorrect result becausetsc
cannot handle the default import(such asimport React from 'react'
) of a CommonJs module correctlyCurrently, we always import React using the default import syntax. Additionally, when using
tsc --init
,esModuleInterop
is enabled by default. For these reasons, I believe it is time to setesModuleInterop
as the default configuration for theparse
API.