Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change default value of show_references_in_quick_panel to true #2350

Merged
merged 3 commits into from
Nov 1, 2023

Conversation

rchl
Copy link
Member

@rchl rchl commented Oct 31, 2023

The panel feels archaic and less user-friendly due to issue with navigating results.
The default should IMO be as close to what ST offers as possible.

@predrag-codetribe
Copy link

I am pretty much like panels :)

Even with that being said,
I would give show_references_in_quick_panel: true a try,
as I think it is just a matter of getting use to it.

If someone is not getting use to it, they can just set show_references_in_quick_panel: false, so it is not a big deal.

The quick panel has one bonus, you can filter with text in it.
There are still some improvements, like moving the repeating LSP-* label on the right to some other place(ideally displaying just one label at some place)
Screenshot 2023-10-31 at 22 42 58

But that is just something I've noticed,
not something that needs to be addressed.

@jwortmann
Copy link
Member

I think the bottom panel follows the "Find in Files" panel design, so it is also close to what ST offers in some way. But I do prefer the quick panel which allows to navigate quickly with the arrow keys.

The update message skips 3 minor versions though...

@rchl
Copy link
Member Author

rchl commented Nov 1, 2023

The update message skips 3 minor versions though...

Yeah, doesn't make much sense. Ideally we'd follow a semantic versioning and indicate a breaking change like this one with a bump of major component but that seems a bit overkill. And one could also argue that major bumps should be reserved for breaking changes in context of ST version.

@rchl
Copy link
Member Author

rchl commented Nov 1, 2023

I think the bottom panel follows the "Find in Files" panel design, so it is also close to what ST offers in some way. But I do prefer the quick panel which allows to navigate quickly with the arrow keys.

But ST has also "Find references" functionality and that one uses quick panel. That's what I'm aligning with.

@rchl rchl merged commit da9abf3 into main Nov 1, 2023
4 checks passed
@rchl rchl deleted the fix/show_references_in_quick_panel branch November 1, 2023 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants