Adjust OVN TransitSwitchIP initialization #3192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've observed E2E failures on route agent restart that was caused by the addition of the TransitSwitchIP refactoring. On code inspection, there's a potential timing issue related to initialization of the TransitSwitchIP. The Init method is called by NonGatewayRouteHandler.Init however the NewNonGatewayRouteController is started before that in Handler.Init so, depending on timing, nonGatewayRouteCreatedOrUpdated could get invoked prior to initialization of the TransitSwitchIP, in which case it would observe an empty IP. To avoid this, move the TransitSwitchIP.Init call to Handler.Init prior to starting the NewNonGatewayRouteController. Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
tpantelis
requested review from
Oats87,
skitt,
sridhargaddam,
vthapar and
yboaron
as code owners
|
🤖 Created branch: z_pr3192/tpantelis/transit_switch_ip |
tpantelis
added
ready-to-test
aswinsuryan
approved these changes
Oct 18, 2024
vthapar
approved these changes
Oct 18, 2024
|
🤖 Closed branches: [z_pr3192/tpantelis/transit_switch_ip] |
|
@tpantelis Does this need to be backported to 0.18.0 as well? |
No - it was added in 0.19 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've observed E2E failures on route agent restart that was caused by the addition of the
TransitSwitchIPrefactoring. On code inspection, there's a potential timing issue related to initialization of theTransitSwitchIP. TheInitmethod is called byNonGatewayRouteHandler.Inithowever theNewNonGatewayRouteControlleris started before that inHandler.Initso, depending on timing,nonGatewayRouteCreatedOrUpdatedcould get invoked prior to initialization of theTransitSwitchIP, in which case it would observe an empty IP.To avoid this, move the
TransitSwitchIP.Initcall toHandler.Initprior to starting theNewNonGatewayRouteController.