Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address identical functions in RA health checker #3201

Merged
merged 2 commits into from
Nov 11, 2024

Conversation

tpantelis
Copy link
Contributor

RemoteEndpointCreated and RemoteEndpointUpdated are identical and is reported by Sonar as an issue. Change one to call the other.

@submariner-bot
Copy link
Contributor

🤖 Created branch: z_pr3201/tpantelis/fix_dup_funcs
🚀 Full E2E won't run until the "ready-to-test" label is applied. I will add it automatically once the PR has 2 approvals, or you can add it manually.

RemoteEndpointCreated and RemoteEndpointUpdated are identical
and is reported by Sonar as an issue. Change one to call the other.

Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
@submariner-bot submariner-bot added the ready-to-test When a PR is ready for full E2E testing label Nov 11, 2024
@skitt skitt enabled auto-merge (rebase) November 11, 2024 13:08
@skitt skitt merged commit 44bc2c1 into submariner-io:devel Nov 11, 2024
38 checks passed
@submariner-bot
Copy link
Contributor

🤖 Closed branches: [z_pr3201/tpantelis/fix_dup_funcs]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-test When a PR is ready for full E2E testing
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants