Allow the gateway to wait for node readiness #3222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
tpantelis
requested review from
Oats87,
skitt,
sridhargaddam,
vthapar and
yboaron
as code owners
|
🤖 Created branch: z_pr3222/tpantelis/gw_wait_for_node |
tpantelis
added
the
backport
tpantelis
added a commit
to tpantelis/submariner-operator
that referenced
this pull request
Nov 20, 2024
See submariner-io/submariner#3222 Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
skitt
approved these changes
Nov 20, 2024
dfarrell07
approved these changes
Nov 20, 2024
|
🤖 Closed branches: [z_pr3222/tpantelis/gw_wait_for_node] |
tpantelis
added a commit
to tpantelis/submariner-operator
that referenced
this pull request
Nov 21, 2024
See submariner-io/submariner#3222 Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
tpantelis
added a commit
to submariner-io/submariner-operator
that referenced
this pull request
Nov 21, 2024
See submariner-io/submariner#3222 Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
tpantelis
added a commit
to tpantelis/submariner-operator
that referenced
this pull request
Nov 21, 2024
See submariner-io/submariner#3222 Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
tpantelis
added a commit
to submariner-io/submariner-operator
that referenced
this pull request
Nov 22, 2024
See submariner-io/submariner#3222 Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
tpantelis
added a commit
to tpantelis/submariner-operator
that referenced
this pull request
Nov 22, 2024
See submariner-io/submariner#3222 Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've observed instances where the gateway pod may fail to connect to the K8s API server on startup after failover on node restart. While it eventually succeeds on pod restart, the initial pod failure can cause E2E to fail. We suspect this is b/c the node, specifically it's networking, isn't fully ready when the pod starts up. To alleviate this, add functionality to the gateway pod to wait for the node to be ready using a variant of the gateway invoked using the
SUBMARINER_WAITFORNODEenvironment variable as is done with the route agent.The code to perform the wait was refactored from route agent main to the node module for re-use. See individual commits for details.