Added NBA Stats plugin #1115
Open
Added NBA Stats plugin #1115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 2, 2023 16:44
pnhofmann
reviewed
Jun 7, 2023
| } | ||
| # main function | ||
|
|
||
| def __call__(self, jarvis): |
There was a problem hiding this comment.
Traceback (most recent call last):
File "/data/git/Jarvis/jarviscli/CmdInterpreter.py", line 286, in try_do
do(self, s)
File "/data/git/Jarvis/jarviscli/plugin.py", line 226, in _plugin_run_with_network_error
run_func(jarvis, s)
File "/data/git/Jarvis/jarviscli/plugin.py", line 208, in run
self._backend[0](jarvis.get_api(), s)
TypeError: __call__() takes 2 positional arguments but 3 were given
It's call(self, jarvis, s)
pnhofmann
reviewed
Jun 7, 2023
| @@ -88,6 +88,7 @@ Creating a test is optional but never a bad idea ;). | |||
| - Portaudio + python-devel packages for voice control | |||
| - ``notify-send`` on Linux if you want to receive *nice* and desktop-notification instead of *ugly* pop up windows (e.g. Ubuntu do ``sudo apt install libnotify-bin``) | |||
| - ``ffmpeg`` if you want ``music`` to download songs as .mp3 instead of .webm | |||
| - ``nba-api`` if you want ``nbastats`` to run | |||
There was a problem hiding this comment.
you can just add nba-api in installer/requirements.txt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first contribution to an open-source project. Please let me know what I should change/fix.