Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop storing all_search fields #1899

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Stop storing all_search fields #1899

wants to merge 1 commit into from

Conversation

cbeer
Copy link
Member

@cbeer cbeer commented Jul 28, 2020

AFAICT, the comment about highlighting came from upstream in searchworks. We've never used that field for highlighting in exhibits (and, in fact, override hl.fl to just those full tet fields)

@corylown
Copy link
Contributor

corylown commented Jul 24, 2024

We are displaying hit highlights for OCR content such as in this sample exhibit: https://exhibits.stanford.edu/jarndyce-test/feature/search-across

Need to verify whether this is powered by the all_search field or not before we do this.

The hit highlighting for full text uses the full_text_tesimv so would not be impacted if we stop storing the all_search field

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Maintenance or dev-specific - will need dev help to prioritize
Development

Successfully merging this pull request may close these issues.

2 participants