[WIP] Migrate from libsass to dart sass #2284
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This helps us so that we can migrate from libsass to dart sass
It is no longer used in Rails 7
houndci-bot
reviewed
Jan 24, 2023
| @@ -0,0 +1,2 @@ | |||
| // Entry point for your Sass build | |||
| @import "base"; | |||
There was a problem hiding this comment.
Files should end with a trailing newline
| @import 'sul-styles/su_web_colors'; | ||
| @import 'sul-styles/su_primary_colors'; | ||
| @import 'sul-styles/variables'; | ||
| @import 'sul-styles/sul_footer'; |
There was a problem hiding this comment.
Files should end with a trailing newline
Prefer double-quoted strings
| @@ -0,0 +1,4 @@ | |||
| @import 'sul-styles/su_web_colors'; | |||
| @import 'sul-styles/su_primary_colors'; | |||
| @import 'sul-styles/variables'; | |||
| @@ -0,0 +1,4 @@ | |||
| @import 'sul-styles/su_web_colors'; | |||
| @import 'sul-styles/su_primary_colors'; | |||
| @@ -0,0 +1,4 @@ | |||
| @import 'sul-styles/su_web_colors'; | |||
| @@ -0,0 +1,34 @@ | |||
| /* | |||
|
|
||
| li { | ||
| display: inline; | ||
| margin: 0 13px 3px 0; |
There was a problem hiding this comment.
Shorthands of length 4 are not allowed. Value was 0 13px 3px 0
| clear: both; | ||
| margin-top: -1 * $footer-height; | ||
| min-height: $footer-height; | ||
| padding: 0 !important; |
| @@ -0,0 +1,77 @@ | |||
| #su-content { | |||
| padding-bottom: $footer-height !important; | |||
| $sul-footer-border-top-color: $color-beige-20; | ||
| $footer-height: 200px; | ||
| $sul-footer-shadow-color: rgba(0, 0, 0, 0.2); | ||
| $sul-footer-shadow: 0 4px 8px -8px $sul-footer-shadow-color inset; |
There was a problem hiding this comment.
Files should end with a trailing newline
houndci-bot
reviewed
Jan 24, 2023
| @@ -1,4 +1,4 @@ | |||
| @import 'blacklight_range_limit/blacklight_range_limit'; | |||
| @import 'blacklight-range-limit/app/assets/stylesheets/blacklight_range_limit/blacklight_range_limit'; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires exhibits to npm it's assets.