Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add collapsable hit highlighting #99

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

cbeer
Copy link
Member

@cbeer cbeer commented Nov 14, 2015

A quick attempt at projectblacklight/spotlight#1175 for discussion.

See also: projectblacklight/spotlight#1227 and projectblacklight/spotlight#1228 for more background info.

screen shot 2015-11-13 at 4 12 30 pm

(connects to projectblacklight/spotlight#1175)

  • create fixture data with full text content
  • add integration tests to prove it works

// symbol for "opening" panels
content: "\e114";
float: right;
font-family: 'Glyphicons Halflings';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer double-quoted strings

@ggeisler
Copy link

👍

I can only go by the screenshot at the moment, but I wonder if the font size for the "Preview text..." toggle might be better if slightly smaller (0.75em)? It feels slightly too big of a jump from the metadata field labels to me, maybe giving it more importance than it deserves. (I'd also be fine with shipping this now and revisiting the styling details later.)

@cbeer
Copy link
Member Author

cbeer commented Nov 14, 2015

Yeah, the sketch in projectblacklight/spotlight#1175 didn't give me much to go on, so I just threw the bootstrap h4 style on it, assuming we'd do some design.

Before we go much further, though, I think it'd be useful to discuss whether this feature is useful for Feigenbaum (or other exhibits) and/or how much more work we should do.

@cbeer
Copy link
Member Author

cbeer commented Nov 16, 2015

@ndushay: do you know anything about the Solr Boundary Scanners? I'm pretty sure it won't help us here, given the quality of the OCR, but might it be adaptable to find page-level boundaries?

@cbeer cbeer changed the title Add collapsable hit highlighting [WIP] Add collapsable hit highlighting Nov 16, 2015
@cbeer cbeer added icebox and removed in progress labels Nov 16, 2015
@ndushay
Copy link
Contributor

ndushay commented Nov 18, 2015

Looks like Solr Boundary Scanners avail are break iterator (WORD, LINE, SENTENCE, and CHARACTER.) and simple, which seems to look for specific chars. Given OCR junk, having a particular character in our full text to indicate page breaks seems dicey. :-(

@ndushay
Copy link
Contributor

ndushay commented Nov 30, 2015

So far we, have concluded that existing collections with decent quality English full text are:

  • Jarndyce
  • Homebrew
  • GATT (but from TEI)

And that for the future, we should determine how to accession full text created by Abbyy digitization to facilitate indexing (or how to adjust indexing to take the full-text from page level and document level pdfs)

@ndushay
Copy link
Contributor

ndushay commented Nov 30, 2015

See projectblacklight/spotlight#1227 for more info on files ABBYY creates and where the full text is, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants