Add Cornucopia and Guilds second edition and upgrade pack.

[dbgalur]

No description provided.

[sumpfork]

Thanks! I'll try to find time to have a stab at trying it out this weekend. Probably just needs some minor formatting cleanup (pip install pre-commit would do cause this to be done when you git commit) so the linters are happy.

[dbgalur]

I'm trying to debug an issue where the Tournament and Rewards are not showing up as a group if I try to output the "cornucopiaAndGuilds2ndEdition" expansion with "--special-card-groups". (If I output "cornucopia2ndEditionUpgrade" or do not try to group special cards, it does work.).

[dbgalur]

Actually I think there's a logic bug in the filter_sort_cards function in the 'if options.group_special' section. Before that section, all the cards that are part of the 'Tournaments and Prizes' or 'Joust and Rewards' groups appear twice in 'cards', once for each of the two editions they are part of. After that section, as each of the groups have been combined into just one card, that card appears in only one expansion. I suspect its because 'group_cards' is keyed by the group_tag only, and not by the cardset_tag, leaving a random one of them.
It's not entirely clear to me how to even fix that, since it's theoretically possible for the group to continue existing between editions, but some of its members to be removed, in which case the 'group_top' might not be in the same group as the cards removed.. In practice, that's not actually a problem in this case, because the entirety of 'Tournaments and Prizes' has been removed and replaced with 'Joust and Rewards'. Maybe it's worth putting in the simple fix that will fix this bug, and worry about future hypotheticals later.

[sumpfork]

#498

[sumpfork]

Replaced by #517