Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only write version file if supabase directory exists #2408

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

sweatybridge
Copy link
Contributor

@sweatybridge sweatybridge commented Jun 11, 2024

What kind of change does this PR introduce?

Bug fix

What is the current behavior?

Bash completion is sometimes added to ~/.zshrc files resulting in supabase/.temp/cli-latest created in every directory where a new shell is launched.

What is the new behavior?

Only writes the version file if there's an existing supabase directory.

Additional context

Add any other context or screenshots.

@sweatybridge sweatybridge requested a review from a team as a code owner June 11, 2024 08:56
@sweatybridge sweatybridge changed the title fix: do not check version for additional commands fix: only write version file if supabase directory exists Jun 11, 2024
@coveralls
Copy link

coveralls commented Jun 11, 2024

Pull Request Test Coverage Report for Build 9462591335

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • 72 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.09%) to 60.016%

Changes Missing Coverage Covered Lines Changed/Added Lines %
cmd/root.go 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
internal/storage/rm/rm.go 2 89.53%
internal/gen/keys/keys.go 5 11.76%
cmd/root.go 65 9.52%
Totals Coverage Status
Change from base Build 9459290596: -0.09%
Covered Lines: 6870
Relevant Lines: 11447

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 11, 2024

Pull Request Test Coverage Report for Build 9462680245

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • 8 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.05%) to 60.052%

Changes Missing Coverage Covered Lines Changed/Added Lines %
cmd/root.go 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
internal/debug/postgres.go 3 64.86%
internal/gen/keys/keys.go 5 11.76%
Totals Coverage Status
Change from base Build 9459290596: -0.05%
Covered Lines: 6867
Relevant Lines: 11435

💛 - Coveralls

@sweatybridge sweatybridge merged commit d83ccd4 into develop Jun 11, 2024
13 checks passed
@sweatybridge sweatybridge deleted the no-check branch June 11, 2024 09:25
@github-actions github-actions bot mentioned this pull request Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants