Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: inspect storage container before seeding buckets #2731

Merged
merged 3 commits into from
Oct 7, 2024

Conversation

sweatybridge
Copy link
Contributor

@sweatybridge sweatybridge commented Oct 6, 2024

What kind of change does this PR introduce?

Bug fix

What is the current behavior?

db start && db reset throws an error because storage container is missing.

What is the new behavior?

Only seeds storage if local container is started.

Additional context

Add any other context or screenshots.

@sweatybridge sweatybridge requested a review from a team as a code owner October 6, 2024 08:09
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11200220452

Details

  • 4 of 7 (57.14%) changed or added relevant lines in 2 files are covered.
  • 5 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.2%) to 60.253%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/db/reset/reset.go 3 6 50.0%
Files with Coverage Reduction New Missed Lines %
internal/gen/keys/keys.go 5 12.9%
Totals Coverage Status
Change from base Build 11183330771: 0.2%
Covered Lines: 6476
Relevant Lines: 10748

💛 - Coveralls

@sweatybridge sweatybridge merged commit b045039 into develop Oct 7, 2024
9 checks passed
@sweatybridge sweatybridge deleted the seed-reset branch October 7, 2024 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants