feat(realtime_client): Add support for authorized realtime channels with broadcast and presence. #970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vinzent03
requested changes
Jul 10, 2024
| @@ -32,6 +32,8 @@ class RealtimeChannel { | |||
| @internal | |||
| final RealtimeClient socket; | |||
|
|
|||
| late final bool _private; | |||
There was a problem hiding this comment.
I think this attribute should be documented as well like in RealtimeChannelConfig
Vinzent03
approved these changes
Jul 11, 2024
bdlukaa
reviewed
Jul 11, 2024
Co-authored-by: Bruno D'Luka <45696119+bdlukaa@users.noreply.github.com>
Co-authored-by: Bruno D'Luka <45696119+bdlukaa@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Adds support for authorization on broadcast and presence
What is the current behavior?
Authorization is not supported on broadcast or presence allowing anyone to listen to its messages.
What is the new behavior?
Realtime channel created with
private: truewill respect RLS. Read more on the official docs.Related JS PRs