fix: session refresh loop in all request interceptors #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anku255
force-pushed
the
fix/session-refresh-loop
branch
from
caaa078
to
5749205
Compare
porcellus
approved these changes
Jun 5, 2024
rishabhpoddar
requested changes
Jun 9, 2024
lib/src/utilities.dart
Outdated
Comment on lines
377
to
378
| if (maxRetryAttemptsForSessionRefresh != null) | ||
| _maxRetryAttemptsForSessionRefresh = maxRetryAttemptsForSessionRefresh; |
There was a problem hiding this comment.
Added for all the if conditions in that file.
rishabhpoddar
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of change
This PR fixes the session refresh loop in all the request interceptors that occurred when an API returned a 401 response despite a valid session. Interceptors now attempt to refresh the session a maximum of ten times before returning the last API response. The retry limit is configurable via the
maxRetryAttemptsForSessionRefreshoption.Related issues
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)
Documentation changes
(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)
Checklist for important updates
frontendDriverInterfaceSupported.jsonfile has been updated (if needed)lib/src/version.dartpubspec.yamllib/src/version.dartgit tag) in the formatvX.Y.Z, and then find the latest branch (git branch --all) whoseX.Yis greater than the latest released tag.