Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT] Use relative path for MacOS workflow #5130

Merged
merged 1 commit into from
Jul 7, 2024

Conversation

tobbi
Copy link
Contributor

@tobbi tobbi commented Jul 6, 2024

Agreement

By creating a pull request in stk-code, you hereby agree to dual-license your contribution as
GNU General Public License version 3 or any later version and
Mozilla Public License version 2 or any later version.

This includes your previous contribution(s) under the same name of contributor.

Keep the above statement in the pull request comment for agreement.

I do not know if this fixes the MacOS builds. Seems too simple a fix.

@tobbi tobbi changed the title Use relative path for MacOS workflow [DRAFT] Use relative path for MacOS workflow Jul 6, 2024
@tobbi tobbi marked this pull request as ready for review July 6, 2024 21:54
@tobbi
Copy link
Contributor Author

tobbi commented Jul 6, 2024

Just wanted to mention that the builds started failing when the github runner image was updated:

works:

 Image: macos-14-arm64
  Version: 20240625.2
  Included Software: https://github.com/actions/runner-images/blob/macos-14-arm64/20240625.2/images/macos/macos-14-arm64-Readme.md
  Image Release: https://github.com/actions/runner-images/releases/tag/macos-14-arm64%2F20240625.2

Fails:

   Image: macos-14-arm64
  Version: 20240701.9
  Included Software: https://github.com/actions/runner-images/blob/macos-14-arm64/20240701.9/images/macos/macos-14-arm64-Readme.md
  Image Release: https://github.com/actions/runner-images/releases/tag/macos-14-arm64%2F20240701.9

@CodingJellyfish CodingJellyfish merged commit c157a1c into supertuxkart:master Jul 7, 2024
22 checks passed
@CodingJellyfish
Copy link
Member

I'm so sorry, it looks like they don't run dylibbundler when it's not merged, so I wrongly merged it

@tobbi
Copy link
Contributor Author

tobbi commented Jul 7, 2024

Unfortunately, that didn't fix the issue.

@tobbi
Copy link
Contributor Author

tobbi commented Jul 7, 2024

I opened actions/runner-images#10184 for the issue. I'm assuming it's a combination between the dylibbundler and XCode 1.5.0 that's the culprit here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants