Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename AppStream metadata file to a rDNS format #5137

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

AsciiWolf
Copy link
Contributor

@AsciiWolf AsciiWolf commented Aug 4, 2024

Also:

  • Set the component type to desktop-application instead of a deprecated desktop one.
  • Update data/po/update_desktop_file_appdata.py + add the previously added launchable type there.

Agreement

By creating a pull request in stk-code, you hereby agree to dual-license your contribution as
GNU General Public License version 3 or any later version and
Mozilla Public License version 2 or any later version.

This includes your previous contribution(s) under the same name of contributor.

Keep the above statement in the pull request comment for agreement.

Follow-up to the previous PR.

While non-rDNS app IDs still work, they are considered deprecated and not recommended to use.

Please note that after this PR gets merged, it will be necessary to re-generate the pot file / po files.

/cc @CodingJellyfish

Also:
- Set the component type to desktop-application instead of a deprecated desktop one
- Update data/po/update_desktop_file_appdata.py + add the previously added launchable type there
@AsciiWolf
Copy link
Contributor Author

https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#tag-id-generic

The ID must follow a reverse-DNS scheme, consisting of {tld}.{vendor}.{product}, for example org.kde.gwenview or com.hugski.colorhug2. Ownership of {vendor}.{tld} in the domain name system guarantees uniqueness of IDs.

To increase the uniqueness and to distinguish between different pieces of a software suite, it is suggested to append the type name to the component-id in these cases.

(Do not worry about the previous sentence about lowercase letters. Even GNOME uses a mix of lowercase and uppercase for app IDs and there are no problems with it.)

@AsciiWolf
Copy link
Contributor Author

AsciiWolf commented Sep 3, 2024

Any news (or at least a review)?

@qwertychouskie
Copy link
Contributor

Looks good to me, @CodingJellyfish feel free to merge.

@AsciiWolf
Copy link
Contributor Author

@CodingJellyfish Ping. If there is any problem with this PR, please let me know. Thanks!

By the way, don't forget to re-generate the pot file / po files after this PR gets merged.

@deveee
Copy link
Member

deveee commented Sep 22, 2024

Don't you think that pinging so many people so often isn't abusive behavior?

@AsciiWolf
Copy link
Contributor Author

Don't you think that pinging so many people so often isn't abusive behavior?

Maybe a little. On the other hand, do you think that completely ignoring this PR for almost two months (and even ignoring the review from another contributor) is a proper behavior?

If you want to keep ignoring this PR, please at least fix the bug in your update_desktop_file_appdata.py script (fixed as part of this PR) that is currently missing the launchable tag and will damage the AppStream metadata file the next time it is launched.

@qwertychouskie
Copy link
Contributor

Don't you think that pinging so many people so often isn't abusive behavior?

Pinging once when opening the PR and once after 1.5 months is hardly what I would consider excessive. (And the one other ping was me.)

@CodingJellyfish CodingJellyfish merged commit 6663034 into supertuxkart:master Sep 30, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants