-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Tokio requirement and move into a user supplied spawner #82
Open
stevefan1999-personal
wants to merge
9
commits into
surrealdb:main
Choose a base branch
from
stevefan1999-personal:patch-spawner
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Remove Tokio requirement and move into a user supplied spawner #82
stevefan1999-personal
wants to merge
9
commits into
surrealdb:main
from
stevefan1999-personal:patch-spawner
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tested on my WSL2 environment, all system go!
|
Thanks @stevefan1999-personal As mentioned here, will keep this for a future milestone as it will introduce many breaking changes at the moment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of #80 to remove Tokio from the library crate itself. The test and everything else (including the API usage) should still work the same.
However, this is still a major interface change (added a new trait bound) so a semver change is also required.
Together with #81, this should make SurrealKV truly runtime-free, and should be able to seamlessly integrate with other async runtime (smol, async-std) as well.