Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove docker compose files + add GH action to compile examples during CI #397

Merged
merged 30 commits into from
Oct 10, 2024
Merged

Remove docker compose files + add GH action to compile examples during CI #397

merged 30 commits into from
Oct 10, 2024
+103 −161

Conversation

sebsto
Copy link
Contributor

@sebsto sebsto commented Oct 8, 2024

No description provided.

fabianfett
fabianfett reviewed Oct 8, 2024
View reviewed changes
docker/Dockerfile Outdated Show resolved Hide resolved
@sebsto sebsto requested a review from fabianfett October 9, 2024 08:57
@sebsto sebsto changed the title Fix docker compose files + add GH action to compile examples during CI Remove docker compose files + add GH action to compile examples during CI Oct 9, 2024
@sebsto
Copy link
Contributor Author

sebsto commented Oct 9, 2024 •
edited
Loading

@fabianfett Here is a first version of a Matrix that launches integration tests in parallel.
Each example is built on swift-6.0-nigthly and swift-main-nightly

I'm not super happy with the place where the list of example is defined (currently in .github/workflows/examples_matrix.yml) because I don't think we can pass an array as parameter between workflow.
(Ideally, the list of examples should be defined in .github/workflows/pull_request.yml)

@sebsto sebsto requested a review from fabianfett October 9, 2024 13:20
fabianfett
fabianfett reviewed Oct 9, 2024
View reviewed changes
.github/workflows/examples_matrix.yml
Comment on lines +3 to +5
on:
workflow_call:
inputs:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure we need an extra workflow for this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fabianfett This is a matter of separation of concerns. Just like when we create 2 .swift files for two different struct.
In the reporting web view, it doesn't matter if this is a sub workflow or not.

I really don't want to bring this complexity in pull_request.yml. Where would you host this script if not in a separate workflow ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@sebsto
Copy link
Contributor Author

sebsto commented Oct 9, 2024

All green ! Except Swift 6 language mode

  • Examples are built on only one version of Swift Linux (the latest one)
  • I kept a separate file to define the matrix job
image

@sebsto sebsto requested a review from fabianfett October 9, 2024 20:28
@sebsto sebsto mentioned this pull request Oct 9, 2024
Merged
fabianfett
fabianfett approved these changes Oct 10, 2024
View reviewed changes
Copy link
Member

@fabianfett fabianfett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!

@sebsto sebsto merged commit 65061a6 into swift-server:main Oct 10, 2024
14 of 15 checks passed
@sebsto sebsto deleted the sebsto/docker branch October 10, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabianfett fabianfett fabianfett approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sebsto @fabianfett @aryan-25