Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Router refresh #751

Merged
merged 5 commits into from
Nov 3, 2024
Merged

Router refresh #751

merged 5 commits into from
Nov 3, 2024

Conversation

davidon-top
Copy link
Contributor

closes: #335

Copy link

codecov bot commented Nov 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 22 lines in your changes missing coverage. Please review.

Project coverage is 72.33%. Comparing base (ed3cabc) to head (975601a).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/sycamore-router/src/router.rs 0.00% 22 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #751      +/-   ##
==========================================
- Coverage   72.57%   72.33%   -0.25%     
==========================================
  Files          45       45              
  Lines        6531     6553      +22     
==========================================
  Hits         4740     4740              
- Misses       1791     1813      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lukechu10 lukechu10 self-requested a review November 2, 2024 22:43
@lukechu10 lukechu10 added C-enhancement Category: new feature or improvement to existing feature A-router Area: router labels Nov 2, 2024
packages/sycamore-router/src/router.rs Outdated Show resolved Hide resolved
packages/sycamore-router/src/router.rs Show resolved Hide resolved
packages/sycamore-router/src/router.rs Outdated Show resolved Hide resolved
packages/sycamore-router/src/router.rs Show resolved Hide resolved
packages/sycamore-router/src/router.rs Outdated Show resolved Hide resolved
davidon-top and others added 2 commits November 3, 2024 14:39
Co-authored-by: Luke <37006668+lukechu10@users.noreply.github.com>
@lukechu10 lukechu10 merged commit 47ca5f1 into sycamore-rs:main Nov 3, 2024
9 of 11 checks passed
@davidon-top davidon-top deleted the router_reload branch November 3, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-router Area: router C-enhancement Category: new feature or improvement to existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Router reload
2 participants