Simplify navigate functions in router

[lukechu10]

Simplify the implementations of the navigate, navigate_replace, and navigate_no_history functions by sharing more code.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no suggestions.

Comments skipped due to low confidence (3)

packages/sycamore-router/src/router.rs:399

• [nitpick] Ensure consistency in error messages across the codebase. The message 'cannot navigate outside of a Router' should be consistent with similar messages.

assert!(pathname.get().is_some(), "cannot navigate outside of a Router");

packages/sycamore-router/src/router.rs:419

• [nitpick] Ensure consistency in error messages across the codebase. The message 'cannot refresh outside of a Router' should be consistent with similar messages.

assert!(pathname.get().is_some(), "cannot refresh outside of a Router");

packages/sycamore-router/src/router.rs:10

• The line 'pathname.ends_with('/')' does not modify the pathname variable. Consider removing this line if it is not serving any purpose.

pathname.ends_with('/');

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 20 lines in your changes missing coverage. Please review.

Project coverage is 71.50%. Comparing base (0e82e2e) to head (c882486).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
packages/sycamore-router/src/router.rs	0.00%	20 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #759      +/-   ##
==========================================
+ Coverage   71.32%   71.50%   +0.17%     
==========================================
  Files          45       45              
  Lines        6648     6632      -16     
==========================================
  Hits         4742     4742              
+ Misses       1906     1890      -16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no suggestions.

Comments skipped due to low confidence (1)

packages/sycamore-router/src/router.rs:359

• The line 'pathname.ends_with('/')' is redundant and does not affect the code. It should be removed.

pathname.ends_with('/');

[lukechu10]

Copilot review is actually pretty cool!