Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mb trim functions #469

Merged
merged 2 commits into from
Jun 20, 2024
Merged

Mb trim functions #469

merged 2 commits into from
Jun 20, 2024

Conversation

Fan2Shrek
Copy link
Contributor

Fixes #458

Implementaion of mb_trim, mb_ltrim and mb_rtrim
Tests from the php-src repository

@Ayesh
Copy link
Contributor

Ayesh commented Mar 31, 2024

Upstream issue php/php-src#13815 might affect the targets we are about to write polyfill for.

@zonuexe
Copy link
Contributor

zonuexe commented Apr 24, 2024

php/php-src#13820 has been merged.

src/Mbstring/Mbstring.php Outdated Show resolved Hide resolved
src/Mbstring/Mbstring.php Outdated Show resolved Hide resolved
src/Php84/Php84.php Outdated Show resolved Hide resolved
src/Mbstring/Mbstring.php Outdated Show resolved Hide resolved
tests/Mbstring/MbstringTest.php Outdated Show resolved Hide resolved
@Fan2Shrek Fan2Shrek force-pushed the mb_trim_functions branch 2 times, most recently from d124eb9 to 9b57970 Compare June 19, 2024 20:55
src/Php84/bootstrap.php Outdated Show resolved Hide resolved
@nicolas-grekas
Copy link
Member

Thank you @Fan2Shrek.

@nicolas-grekas nicolas-grekas merged commit 17a0fbb into symfony:1.x Jun 20, 2024
6 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PHP 8.4] mb_trim, mb_ltrim, and mb_rtrim polyfills
5 participants