Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 7.2+ #55

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

PHP 7.2+ #55

wants to merge 5 commits into from

Commits on Nov 30, 2020

  1. Fix for PHP 7.2 and count()

    Alexander Rutz committed Nov 30, 2020
    Configuration menu
    Copy the full SHA
    5166aa6 View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2020

  1. class.xmlimporter.php - switch is_countable() to array()

    On PHP 7.2 `is_countable` creates an undefined function. `is_countable` is not available until PHP 7.3, <https://www.php.net/manual/en/function.is-countable.php>. 
    
    In PHP 7.3, I get this error... "count(): Parameter must be an array or an object that implements Countable".
    
    BUT, I found this... instead of `is_countable($value)`, **it works with `array($value)`** which I got from this Stack Overflow post, <https://stackoverflow.com/a/59818642>.
    bzerangue authored Dec 1, 2020
    Configuration menu
    Copy the full SHA
    287d1da View commit details
    Browse the repository at this point in the history
  2. Merge pull request #1 from bzerangue/bzerangue-patch-1

    class.xmlimporter.php - switch is_countable() to array()
    animaux authored Dec 1, 2020
    Configuration menu
    Copy the full SHA
    493cb72 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2fd8caf View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2021

  1. Update extension.meta.xml

    Fixed the less than character as < is invalid and should be &lt; 
    
    That character caused an error in the installation process
    bzerangue authored Jan 4, 2021
    Configuration menu
    Copy the full SHA
    62830c1 View commit details
    Browse the repository at this point in the history