Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replace buildcache with ccache #1482

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

feat: replace buildcache with ccache #1482

wants to merge 2 commits into from

Conversation

limpbrains
Copy link
Collaborator

Description

Please include a summary of changes and which issues are fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Linked Issues/Tasks

Add any links to GitHub issues or Asana tasks that are relevant to this pull request.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (improving code without creating new functionality)

Tests

  • Detox test
  • Unit test
  • No test

Screenshot / Video

Insert relevant screenshot / recording

QA Notes

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce during the Bitkit testing session. You can also leave a video of the PR in action.

@limpbrains
Copy link
Collaborator Author

image image

@limpbrains
Copy link
Collaborator Author

limpbrains commented Jan 19, 2024

First run after ccache:
Build time 5m

ccache stats
  /usr/local/bin/ccache -s
  Cacheable calls:   2170 / 2170 (100.0%)
    Hits:            2170 / 2170 (100.0%)
      Direct:        2170 / 2170 (100.0%)
      Preprocessed:     0 / 2170 ( 0.00%)
    Misses:             0 / 2170 ( 0.00%)
  Local storage:
    Cache size (GB):  0.5 /  0.5 (97.24%)
    Hits:            2170 / 2170 (100.0%)
    Misses:             0 / 2170 ( 0.00%)

@ovitrif
Copy link
Contributor

ovitrif commented Apr 9, 2024

@limpbrains Any reasons why we wouldn't merge this sooner rather than later?
I can help w/ reviewing, though IMHO it's more like if the CI works then things must work 🤷🏻

@limpbrains
Copy link
Collaborator Author

It did not provide any noticeable speed improvement that I was hoping for, only adding complexity. I will revisit after we get a new Mac for testing.

@ovitrif
Copy link
Contributor

ovitrif commented Apr 9, 2024

It did not provide any noticeable speed improvement that I was hoping for, only adding complexity. I will revisit after we get a new Mac for testing.

Gotcha, I agree w/ your point though :)
Maybe worth revisiting if now that we're on new RN speed differences are more obvious 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants