Mission board #919
Mission board #919
Conversation
fixup w move manifesto to modal
There was a problem hiding this comment.
Whoa, tons of work here! LGTM. @dtbuchholz can you give this a skim as well? lots of additions.
garage/src/abis/MissionsManager.ts
Outdated
There was a problem hiding this comment.
would it be cleaner to have this as part of the rigs package vs. manual abi?
There was a problem hiding this comment.
Yes definitely. We actually export the generated types from typechain in the rigs package but we can't use them, I don't remember if it is because they are just incompatible with wagmi or if it has something to do with the way they are exported from the rigs package but that would definitely be much nicer
| expectedChain={secondaryChain} | ||
| isDisabled={["querying", "success"].includes(txnState)} | ||
| onClick={() => | ||
| setContributionAcceptedState(contribution.id, true, reason) |
There was a problem hiding this comment.
should the admin contribution approval process work in this PR? i tried both accepting/rejecting with the admin wallet in the admin UI, and neither worked (accepted value in table is still null). some screenshots:
- attempting to accept (note: both the reject/accept buttons spin...not a big deal but calling it out in case it helps troubleshoot):
- error shown after waiting for the approve tx to finalize:
- and upon refreshing, the second row (the one i tried to approve) is still pending:
There was a problem hiding this comment.
hm yes that should work, I'll take a look
There was a problem hiding this comment.
ah, I forgot to give the admin wallet permission to update the contributions table. hm, maybe I should update the contract & have approvals go through the contract instead, that way we don't have to remember to give it both the admin role and those permissions
There was a problem hiding this comment.
|
@dtbuchholz @sanderpick can I get a re-approval on this PR? the reviews got dismissed when dtb pushed a commit. I also added three commits:
-- The deployment won't work because this PR needs the |
|
let's merge it to staging and I can work on the deployment of the package / contract / tables |
Ah actually I can't haha, it requires all checks to pass. I can add back the temp change that hardcodes the staging dev into
|
|
ah yeah. i can just do the package release now and then you can make the changes here. one sec |
Signed-off-by: Sander Pick <sanderpick@gmail.com>
|
pushed 0.3.3-pre0 |
Closes RIG-59, RIG-60, RIG-61, RIG-62, RIG-64