Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Garage: update admin page to check admin permissions #922

Merged

Conversation

datadanne
Copy link
Contributor

Adds admin permission checks for proposals & missions. I don't think there is an api for checking if an account has been granted permission to write to a table using GRANT, so we can't check if the account can give out ft rewards.

image

Closes RIG-68

@linear
Copy link

linear bot commented Sep 19, 2023

sanderpick
sanderpick previously approved these changes Sep 20, 2023
Copy link
Member

@sanderpick sanderpick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Base automatically changed from staging to main September 20, 2023 16:39
@sanderpick sanderpick dismissed their stale review September 20, 2023 16:39

The base branch was changed.

@sanderpick sanderpick changed the base branch from main to staging September 20, 2023 19:18
@datadanne datadanne merged commit df1bf43 into staging Sep 21, 2023
6 checks passed
@datadanne datadanne deleted the datadanne/update-admin-page-to-check-admin-permissions branch September 21, 2023 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants