-
-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial support for wasm-pack #338
base: main
Are you sure you want to change the base?
Conversation
cacb1a3
to
fbe8092
Compare
Thanks! I haven't reviewed the changes yet, but I'm very excited about this. Personally, I would prefer to support this as a subcommand (as said in #221 (comment)), as I find it confusing when the accepted flags change drastically depending on the presence or absence of specific flags. (This is also why we split the functionality of |
e40cfa6
to
22f709d
Compare
I've updated it to use a subcommand. It's now working as you would expect.
You can also do the following:
wasm-pack runs always return exactly one profraw so I use that to my advantage to figure out which object files I need to evaluate that specific run. Still need to clean up some unwraps and so on but I'm happy with the logic. |
a820cec
to
59cba33
Compare
0840e84
to
b57b1c7
Compare
I've documented the safety of the unwraps and think I'm ready here. wasm-pack seems to be a bit slow on merging at the moment so I guess this will remain stale for a while here. |
The tests are failing because I added |
e1a00ba
to
22fce4e
Compare
Hmm doesn't seem I can. @taiki-e do you have any idea why |
22fce4e
to
dac1603
Compare
2a48173
to
6f4700a
Compare
How does this PR looks now that rustwasm/wasm-bindgen#4060 has been merged? (instead of rustwasm/wasm-bindgen#3782 ) |
I'm sorry but I don't have the capacity to look into this at the current time. I might be more free in around a month to do the rebase. |
932a369
to
67a45bf
Compare
Fixes #337.
Fixes #221.
Requires rustwasm/wasm-bindgen#3782.
Will also require a follow-up PR in wasm-pack but that will have trivial changes.
The changes made in this PR are still in a very rough state.
Before I turn this into a non-draft I'm mainly looking to get feedback about whether this is something you would be willing to include here.
Usage
Enable the
unstable-coverage
feature in thewasm-bindgen-test
dependency.Mixing WASM and non-WASM
Doing the following works:
However, you need to do the following:
which is unfortunate.
I'll look into a bit and see what I find out.
@njelich do you maybe have any comments on this?