Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: send operation selection set to graphql upstream. #3106

Open
wants to merge 29 commits into
base: main
Choose a base branch
from

Conversation

laststylebender14
Copy link
Contributor

@laststylebender14 laststylebender14 commented Nov 13, 2024

Summary:
Briefly describe the changes made in this PR.

Issue Reference(s):
Fixes #3088

Build & Testing:

  • I ran cargo test successfully.
  • I have run ./lint.sh --mode=fix to fix all linting issues raised by ./lint.sh --mode=check.

Checklist:

  • I have added relevant unit & integration tests.
  • I have updated the documentation accordingly.
  • I have performed a self-review of my code.
  • PR follows the naming convention of <type>(<optional scope>): <title>

@github-actions github-actions bot added the type: fix Iterations on existing features or infrastructure. label Nov 13, 2024
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 61.83206% with 100 lines in your changes missing coverage. Please review.

Project coverage is 86.55%. Comparing base (fb0974d) to head (a24351c).

Files with missing lines Patch % Lines
src/core/json/graphql.rs 9.27% 88 Missing ⚠️
src/core/jit/model.rs 76.47% 4 Missing ⚠️
src/core/json/borrow.rs 0.00% 3 Missing ⚠️
src/core/json/serde.rs 0.00% 3 Missing ⚠️
src/core/document.rs 98.03% 1 Missing ⚠️
src/core/graphql/request_template.rs 94.73% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3106      +/-   ##
==========================================
- Coverage   86.87%   86.55%   -0.33%     
==========================================
  Files         276      277       +1     
  Lines       26873    27093     +220     
==========================================
+ Hits        23347    23450     +103     
- Misses       3526     3643     +117     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@laststylebender14 laststylebender14 added the ci: benchmark Runs benchmarks label Nov 14, 2024
Copy link

🐰 Bencher Report

Branch3106/merge
Testbedbenchmarking-runner

⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results
BenchmarkLatencynanoseconds (ns)
from_json_bench📈 view plot
⚠️ NO THRESHOLD
6,180,100.00
group_by📈 view plot
⚠️ NO THRESHOLD
486.83
input/args.missing📈 view plot
⚠️ NO THRESHOLD
22.24
input/args.nested.existing📈 view plot
⚠️ NO THRESHOLD
42.29
input/args.nested.missing📈 view plot
⚠️ NO THRESHOLD
36.66
input/args.root📈 view plot
⚠️ NO THRESHOLD
38.13
input/headers.existing📈 view plot
⚠️ NO THRESHOLD
30.64
input/headers.missing📈 view plot
⚠️ NO THRESHOLD
29.77
input/value.missing📈 view plot
⚠️ NO THRESHOLD
22.22
input/value.nested.existing📈 view plot
⚠️ NO THRESHOLD
42.76
input/value.nested.missing📈 view plot
⚠️ NO THRESHOLD
35.13
input/value.root📈 view plot
⚠️ NO THRESHOLD
36.33
input/vars.existing📈 view plot
⚠️ NO THRESHOLD
8.16
input/vars.missing📈 view plot
⚠️ NO THRESHOLD
10.48
synth_nested📈 view plot
⚠️ NO THRESHOLD
95,324.00
synth_nested_borrow📈 view plot
⚠️ NO THRESHOLD
41,129.00
test_batched_body📈 view plot
⚠️ NO THRESHOLD
1,877.40
test_batched_body #2📈 view plot
⚠️ NO THRESHOLD
1,512,000.00
test_data_loader📈 view plot
⚠️ NO THRESHOLD
395,490.00
test_handle_request📈 view plot
⚠️ NO THRESHOLD
128,440.00
test_handle_request_jit📈 view plot
⚠️ NO THRESHOLD
62,087.00
test_http_execute_method📈 view plot
⚠️ NO THRESHOLD
15,841.00
with_mustache_expressions📈 view plot
⚠️ NO THRESHOLD
1,134.10
with_mustache_literal📈 view plot
⚠️ NO THRESHOLD
702.27
🐰 View full continuous benchmarking report in Bencher

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci: benchmark Runs benchmarks type: fix Iterations on existing features or infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug in the nested queries when working with @graphql
1 participant