Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix until does not update when state.property is changed , stays one state behind. #109

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

pwliuab
Copy link

@pwliuab pwliuab commented Apr 2, 2022

fix until does not update when state.property is changed , stays one state behind.

  • adding !this.state.isStartedCountDown and this.props.until !== this.preState.until in componentDidUpdate to check intial update
  • one state behind that's because this.props.until == this.preProp.until is always true, intially.

@rayyanekaputra
Copy link

im new, how do you pull this as an import CountDown from 'react-native-countdown-component'; ? or do i need to reinstall the whole library but with your branch? how do i achieve that? thank youu

@pwliuab
Copy link
Author

pwliuab commented May 20, 2022

im new, how do you pull this as an import CountDown from 'react-native-countdown-component'; ? or do i need to reinstall the whole library but with your branch? how do i achieve that? thank youu

you can first import the original countdown. Then, you go to the node modules of the original version.
Find out the 'react-native-countdown-component' Then, take a look to my pull request, see what is added,
you can fix it by adding my changes manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants