feat: omit content-type header when no parameters are present (#1169)

tangcent · Oct 15, 2024 · 85eb47a · 85eb47a
1 parent bf67a5c
commit 85eb47a
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 46 deletions.
diff --git a/...-plugin/src/main/kotlin/com/itangcent/idea/plugin/api/export/core/RequestClassExporter.kt b/...-plugin/src/main/kotlin/com/itangcent/idea/plugin/api/export/core/RequestClassExporter.kt
@@ -562,12 +562,13 @@ abstract class RequestClassExporter : ClassExporter {
             )
         }
 
-        if (request.hasBodyOrForm()) {
-            requestBuilderListener.addHeaderIfMissed(
-                methodExportContext,
-                request, "Content-Type", "application/x-www-form-urlencoded"
-            )
-        }
+        // no longer need to set content-type here
+        //if (request.hasBodyOrForm()) {
+        //    requestBuilderListener.addHeaderIfMissed(
+        //        methodExportContext,
+        //        request, "Content-Type", "application/x-www-form-urlencoded"
+        //    )
+        //}
 
     }
 

diff --git a/...ort.markdown.MarkdownApiExporterTest.CustomizedDirectorySpringMarkdownApiExporterTest.txt b/...ort.markdown.MarkdownApiExporterTest.CustomizedDirectorySpringMarkdownApiExporterTest.txt
@@ -750,7 +750,6 @@ test apis
 
 | `name` | `value` | `desc` |
 | ------------ | ------------ | ----: |
-| Content-Type | application/x-www-form-urlencoded |  |
 | token |  | auth token |
 
 
@@ -799,7 +798,6 @@ test apis
 
 | `name` | `value` | `desc` |
 | ------------ | ------------ | ----: |
-| Content-Type | application/x-www-form-urlencoded |  |
 | token |  | auth token |
 
 

diff --git a/...in.api.export.markdown.MarkdownApiExporterTest.DirectorySpringMarkdownApiExporterTest.txt b/...in.api.export.markdown.MarkdownApiExporterTest.DirectorySpringMarkdownApiExporterTest.txt
@@ -748,7 +748,6 @@ test apis
 
 | name | value | required | desc |
 | ------------ | ------------ | ------------ | ------------ |
-| Content-Type | application/x-www-form-urlencoded | YES |  |
 | token |  | YES | auth token |
 
 
@@ -797,7 +796,6 @@ test apis
 
 | name | value | required | desc |
 | ------------ | ------------ | ------------ | ------------ |
-| Content-Type | application/x-www-form-urlencoded | YES |  |
 | token |  | YES | auth token |
 
 

diff --git a/...lugin.api.export.postman.PostmanApiExporterTest.DirectorySpringPostmanApiExporterTest.txt b/...lugin.api.export.postman.PostmanApiExporterTest.DirectorySpringPostmanApiExporterTest.txt
@@ -1421,12 +1421,6 @@
             "method": "POST",
             "description": "",
             "header": [
-              {
-                "key": "Content-Type",
-                "value": "application/x-www-form-urlencoded",
-                "type": "text",
-                "description": ""
-              },
               {
                 "key": "token",
                 "value": "",
@@ -1454,12 +1448,6 @@
                 "method": "POST",
                 "description": "",
                 "header": [
-                  {
-                    "key": "Content-Type",
-                    "value": "application/x-www-form-urlencoded",
-                    "type": "text",
-                    "description": ""
-                  },
                   {
                     "key": "token",
                     "value": "",
@@ -1517,12 +1505,6 @@
             "method": "POST",
             "description": "",
             "header": [
-              {
-                "key": "Content-Type",
-                "value": "application/x-www-form-urlencoded",
-                "type": "text",
-                "description": ""
-              },
               {
                 "key": "token",
                 "value": "",
@@ -1550,12 +1532,6 @@
                 "method": "POST",
                 "description": "",
                 "header": [
-                  {
-                    "key": "Content-Type",
-                    "value": "application/x-www-form-urlencoded",
-                    "type": "text",
-                    "description": ""
-                  },
                   {
                     "key": "token",
                     "value": "",

diff --git a/...nt.idea.plugin.api.export.yapi.YapiApiExporterTest.DirectorySpringYapiApiExporterTest.txt b/...nt.idea.plugin.api.export.yapi.YapiApiExporterTest.DirectorySpringYapiApiExporterTest.txt
@@ -486,12 +486,6 @@
     "__v": 0,
     "markdown": "",
     "req_headers": [
-      {
-        "name": "Content-Type",
-        "value": "application/x-www-form-urlencoded",
-        "example": "application/x-www-form-urlencoded",
-        "required": 1
-      },
       {
         "name": "token",
         "value": "",
@@ -528,12 +522,6 @@
     "__v": 0,
     "markdown": "",
     "req_headers": [
-      {
-        "name": "Content-Type",
-        "value": "application/x-www-form-urlencoded",
-        "example": "application/x-www-form-urlencoded",
-        "required": 1
-      },
       {
         "name": "token",
         "value": "",