Use partially evaluated ux_language_text_source functions #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hjanetzek
force-pushed
the
optimize-language-function
branch
from
ffe5a52
to
cade527
Compare
|
Looking at it again now: This change would break the fast-path for language updates I suggested :) Edit: no this would still work - since on ES our JS StyleContext would need to be recreated after global changes. 'The first self-transforming map style'! |
|
I think I understand what's going on in this PR, but requesting that @bcamper gives it some pro-level JavaScript review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change avoids some string allocations when ux_language/fallback is defined, making it slightly more efficient (at least with duktape)