Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wip] Duktape optimization #1958

Open
wants to merge 49 commits into
base: scene-refactor-base
Choose a base branch
from
Open

[wip] Duktape optimization #1958

wants to merge 49 commits into from

Commits on Dec 7, 2018

  1. Add Platform::shutdown() to stop workers before going to delete Map

    @hjanetzek
    hjanetzek committed Dec 7, 2018
    Configuration menu
    Copy the full SHA
    10a41c8 View commit details
    Browse the repository at this point in the history

  2. Linux: don't let http requests block reading local files

    @hjanetzek
    hjanetzek committed Dec 7, 2018
    Configuration menu
    Copy the full SHA
    08aaee8 View commit details
    Browse the repository at this point in the history

  3. Android: load files asynchronously

    @hjanetzek
    hjanetzek committed Dec 7, 2018
    Configuration menu
    Copy the full SHA
    28a44b3 View commit details
    Browse the repository at this point in the history

  4. Android JNI: call from less threads 

    - enqueue async calls on single thread
    @hjanetzek
    hjanetzek committed Dec 7, 2018
    Configuration menu
    Copy the full SHA
    e90b3cd View commit details
    Browse the repository at this point in the history

  5. drop logging

    @hjanetzek
    hjanetzek committed Dec 7, 2018
    Configuration menu
    Copy the full SHA
    869b27c View commit details
    Browse the repository at this point in the history

  6. Use WeakGlobalRef for android MapController instance 

    - MapController is calling dispose, so it must be alive here
    @hjanetzek
    hjanetzek committed Dec 7, 2018
    Configuration menu
    Copy the full SHA
    1c59e1d View commit details
    Browse the repository at this point in the history

  7. Time logger functions

    @hjanetzek
    hjanetzek committed Dec 7, 2018
    Configuration menu
    Copy the full SHA
    880c052 View commit details
    Browse the repository at this point in the history

  8. Timing from scene load to complete view

    @hjanetzek
    hjanetzek committed Dec 7, 2018
    Configuration menu
    Copy the full SHA
    4daf31c View commit details
    Browse the repository at this point in the history

  9. Merge branch 'platform-work' into scene-refactor-base

    @hjanetzek
    hjanetzek committed Dec 7, 2018
    Configuration menu
    Copy the full SHA
    5e36b4c View commit details
    Browse the repository at this point in the history

  10. Merge branch 'time-logging' into scene-refactor-base

    @hjanetzek
    hjanetzek committed Dec 7, 2018
    Configuration menu
    Copy the full SHA
    3c2d3d5 View commit details
    Browse the repository at this point in the history

  11. Safety check that TextStyle::Param::font exists

    @hjanetzek
    hjanetzek committed Dec 7, 2018
    Configuration menu
    Copy the full SHA
    81619ac View commit details
    Browse the repository at this point in the history

  12. linux cmake: glvnd

    @hjanetzek
    hjanetzek committed Dec 7, 2018
    Configuration menu
    Copy the full SHA
    2c20765 View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2018

  1. fixup Textstyle

    @hjanetzek
    hjanetzek committed Dec 8, 2018
    Configuration menu
    Copy the full SHA
    82f650c View commit details
    Browse the repository at this point in the history

  2. Merge branch 'small-fixes-and-cleanups' into scene-refactor-base

    @hjanetzek
    hjanetzek committed Dec 8, 2018
    Configuration menu
    Copy the full SHA
    25c5684 View commit details
    Browse the repository at this point in the history

  3. JS engine templatification 

    - no allocations for lots of temporary JSValue
- less virtual calls
- a word with only one google result! Yay!
    @hjanetzek
    hjanetzek committed Dec 8, 2018
    Configuration menu
    Copy the full SHA
    22230b0 View commit details
    Browse the repository at this point in the history

  4. Add note to optimize StyleContext

    @hjanetzek
    hjanetzek committed Dec 8, 2018
    Configuration menu
    Copy the full SHA
    7ef75bd View commit details
    Browse the repository at this point in the history

  5. Testing: pass StyleContext to TileBuilder

    @hjanetzek
    hjanetzek committed Dec 8, 2018
    Configuration menu
    Copy the full SHA
    83daaf4 View commit details
    Browse the repository at this point in the history

  6. Benchmark both engines

    @hjanetzek
    hjanetzek committed Dec 8, 2018
    Configuration menu
    Copy the full SHA
    57573af View commit details
    Browse the repository at this point in the history

  7. Duktape optimizations pt1 

    - cache ptr to Tangram::Value for the last requested properties
    @hjanetzek
    hjanetzek committed Dec 8, 2018
    Configuration menu
    Copy the full SHA
    4b9587c View commit details
    Browse the repository at this point in the history

  8. wip: duktape rewrite functions to pass context as arguments

    @hjanetzek
    hjanetzek committed Dec 8, 2018
    Configuration menu
    Copy the full SHA
    66d27c0 View commit details
    Browse the repository at this point in the history

  9. wip: test&bench

    @hjanetzek
    hjanetzek committed Dec 8, 2018
    Configuration menu
    Copy the full SHA
    49df944 View commit details
    Browse the repository at this point in the history

  10. wip: faster Filter key matching

    @hjanetzek
    hjanetzek committed Dec 8, 2018
    Configuration menu
    Copy the full SHA
    56f35c6 View commit details
    Browse the repository at this point in the history

  11. wip save

    @hjanetzek
    hjanetzek committed Dec 8, 2018
    Configuration menu
    Copy the full SHA
    60bf620 View commit details
    Browse the repository at this point in the history

  12. wip: duktape config

    @hjanetzek
    hjanetzek committed Dec 8, 2018
    Configuration menu
    Copy the full SHA
    afdbe68 View commit details
    Browse the repository at this point in the history

  13. Duktape: extstr

    @hjanetzek
    hjanetzek committed Dec 8, 2018
    Configuration menu
    Copy the full SHA
    8ca97e3 View commit details
    Browse the repository at this point in the history

  14. cleanups

    @hjanetzek
    hjanetzek committed Dec 8, 2018
    Configuration menu
    Copy the full SHA
    fcb0051 View commit details
    Browse the repository at this point in the history

  15. Duktape extern string wip

    @hjanetzek
    hjanetzek committed Dec 8, 2018
    Configuration menu
    Copy the full SHA
    ccd9ad0 View commit details
    Browse the repository at this point in the history

  16. bench+test

    @hjanetzek
    hjanetzek committed Dec 8, 2018
    Configuration menu
    Copy the full SHA
    8b8e57a View commit details
    Browse the repository at this point in the history

  17. Testing stash vs properties to keep heap refs safe

    @hjanetzek
    hjanetzek committed Dec 8, 2018
    Configuration menu
    Copy the full SHA
    118d8b7 View commit details
    Browse the repository at this point in the history

  18. Working extstr cache

    @hjanetzek
    hjanetzek committed Dec 8, 2018
    Configuration menu
    Copy the full SHA
    a5ba41f View commit details
    Browse the repository at this point in the history

  19. Use StringCache for different lengths

    @hjanetzek
    hjanetzek committed Dec 8, 2018
    Configuration menu
    Copy the full SHA
    5c9e6fc View commit details
    Browse the repository at this point in the history

  20. how can 'i' get greater than 'usage'?

    @hjanetzek
    hjanetzek committed Dec 8, 2018
    Configuration menu
    Copy the full SHA
    a0fc7e6 View commit details
    Browse the repository at this point in the history

  21. drop

    @hjanetzek
    hjanetzek committed Dec 8, 2018
    Configuration menu
    Copy the full SHA
    56cb69a View commit details
    Browse the repository at this point in the history

  22. Freeze 'global' and feature proxy object

    @hjanetzek
    hjanetzek committed Dec 8, 2018
    Configuration menu
    Copy the full SHA
    651874e View commit details
    Browse the repository at this point in the history

  23. Cleanup BIND_GLOBAL_TO_FUNCTION

    @hjanetzek
    hjanetzek committed Dec 8, 2018
    Configuration menu
    Copy the full SHA
    dd64435 View commit details
    Browse the repository at this point in the history

  24. Try global stringStash array to hold feature property strings 

    - needed to prevent their object to be garbage collected
- instead of storing in feature object
    @hjanetzek
    hjanetzek committed Dec 8, 2018
    Configuration menu
    Copy the full SHA
    13871d7 View commit details
    Browse the repository at this point in the history

  25. clenaups duktape

    @hjanetzek
    hjanetzek committed Dec 8, 2018
    Configuration menu
    Copy the full SHA
    f698d6c View commit details
    Browse the repository at this point in the history

  26. wip: StringProxy

    @hjanetzek
    hjanetzek committed Dec 8, 2018
    Configuration menu
    Copy the full SHA
    03e74ae View commit details
    Browse the repository at this point in the history

  27. >>> wip: Filter upgrade

    @hjanetzek
    hjanetzek committed Dec 8, 2018
    Configuration menu
    Copy the full SHA
    1f61ca8 View commit details
    Browse the repository at this point in the history

  28. Disabled layers can be dropped!

    @hjanetzek
    hjanetzek committed Dec 8, 2018
    Configuration menu
    Copy the full SHA
    48310c6 View commit details
    Browse the repository at this point in the history

  29. save

    @hjanetzek
    hjanetzek committed Dec 8, 2018
    Configuration menu
    Copy the full SHA
    45c6732 View commit details
    Browse the repository at this point in the history

  30. wip: early filter/drop unused feature properties

    @hjanetzek
    hjanetzek committed Dec 8, 2018
    Configuration menu
    Copy the full SHA
    8a4d840 View commit details
    Browse the repository at this point in the history

  31. fix: MockPlatform fallback font

    @hjanetzek
    hjanetzek committed Dec 8, 2018
    Configuration menu
    Copy the full SHA
    14e2638 View commit details
    Browse the repository at this point in the history

  32. StyleContextRecorder tweaks

    @hjanetzek
    hjanetzek committed Dec 8, 2018
    Configuration menu
    Copy the full SHA
    18a2422 View commit details
    Browse the repository at this point in the history

  33. Fix stringcache

    @hjanetzek
    hjanetzek committed Dec 8, 2018
    Configuration menu
    Copy the full SHA
    c4e2703 View commit details
    Browse the repository at this point in the history

  34. squash: bench

    @hjanetzek
    hjanetzek committed Dec 8, 2018
    Configuration menu
    Copy the full SHA
    1f4a238 View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2018

  1. Small PointStyleBuilder optimization 

    - checking for defaultTexture is faster than checking rules
- reduce scope of auto& q = _line[i+1];
    @hjanetzek
    hjanetzek committed Dec 10, 2018
    Configuration menu
    Copy the full SHA
    c25983a View commit details
    Browse the repository at this point in the history

  2. #ifdef TIME_LOGGING

    @hjanetzek
    hjanetzek committed Dec 10, 2018
    Configuration menu
    Copy the full SHA
    a1ffaf1 View commit details
    Browse the repository at this point in the history

  3. Build with system jscore lib

    @hjanetzek
    hjanetzek committed Dec 10, 2018
    Configuration menu
    Copy the full SHA
    31ac99b View commit details
    Browse the repository at this point in the history