-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated icons and more shields #201
Conversation
@bcamper working with @nvkelso , having some problems with shields, in Bubble Wrap and Refill, the same code correctly sizes the spritesheet with %, but in Cinnabar and Walkabout, they are oversized. Any ideas? Bubble Wrap's PR is here for comparison: Looking at Dallas area, here: |
Will take a look but I'll be traveling tomorrow so it might take a bit!
…On Tue, Jan 2, 2018 at 5:22 PM Geraldine Sarmiento ***@***.***> wrote:
@bcamper <https://github.com/bcamper> working with @nvkelso
<https://github.com/nvkelso> , having some problems with shields, in
Bubble Wrap and Refill, the same code correctly sizes the spritesheet with
%, but in Cinnabar and Walkabout, they are oversized. Any ideas? Looking at
Dallas area, here:
http://localhost:7000/#13/32.8687/-96.8095
[image: tangram-13-32 86870--96 80955-20180121719 1]
<https://user-images.githubusercontent.com/466585/34506426-6d4f4804-efe1-11e7-8c97-95cb7220288a.png>
[image: tangram-13-32 86870--96 80955-20180121719]
<https://user-images.githubusercontent.com/466585/34506427-6d6a2f16-efe1-11e7-8178-72289ef773be.png>
[image: tangram-13-32 86870--96 80938-20180121719]
<https://user-images.githubusercontent.com/466585/34506428-6d86c07c-efe1-11e7-8a9e-15337b2fdd37.png>
[image: tangram-13-32 86870--96 80940-20180121719]
<https://user-images.githubusercontent.com/466585/34506429-6dabaf68-efe1-11e7-87e8-a82657d65b6b.png>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#201 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABBXbGcpeFahdJF6Y_G7p1XLBMN4znUks5tGtZfgaJpZM4RRNW8>
.
|
Is the original issue here still a problem? |
@bcamper yes, the weird extra large shields are still a problem in Walkabout (verified just now using latest commits in this branch). |
To close the loop on this: The generic shields that were TOO BIG were from oversized raster texture assets that didn't have size applied from default texture versus the shield textures with oversized raster texture sprites but with accommodating density applied. By resizing the shields to be sane, and setting density: 2 on them, and removing the size in the draw block, the problem is resolved and we reduce total lines of code. |
No description provided.