Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated icons and more shields #201

Merged
merged 9 commits into from
Mar 16, 2018
Merged

updated icons and more shields #201

merged 9 commits into from
Mar 16, 2018

Conversation

sensescape
Copy link
Member

No description provided.

@sensescape
Copy link
Member Author

sensescape commented Jan 3, 2018

@bcamper working with @nvkelso , having some problems with shields, in Bubble Wrap and Refill, the same code correctly sizes the spritesheet with %, but in Cinnabar and Walkabout, they are oversized. Any ideas?

Bubble Wrap's PR is here for comparison:
tangrams/bubble-wrap#262

Looking at Dallas area, here:
http://localhost:7000/#13/32.8687/-96.8095

tangram-13-32 86870--96 80955-20180121719 1
tangram-13-32 86870--96 80955-20180121719
tangram-13-32 86870--96 80938-20180121719
tangram-13-32 86870--96 80940-20180121719

@bcamper
Copy link
Member

bcamper commented Jan 3, 2018 via email

@bcamper
Copy link
Member

bcamper commented Jan 28, 2018

Is the original issue here still a problem?

@nvkelso
Copy link
Member

nvkelso commented Jan 29, 2018

@bcamper yes, the weird extra large shields are still a problem in Walkabout (verified just now using latest commits in this branch).

@nvkelso nvkelso merged commit 3c1abb8 into gh-pages Mar 16, 2018
@nvkelso nvkelso deleted the sensescape/more-shields branch March 16, 2018 18:45
@nvkelso
Copy link
Member

nvkelso commented Mar 31, 2018

To close the loop on this:

The generic shields that were TOO BIG were from oversized raster texture assets that didn't have size applied from default texture versus the shield textures with oversized raster texture sprites but with accommodating density applied. By resizing the shields to be sane, and setting density: 2 on them, and removing the size in the draw block, the problem is resolved and we reduce total lines of code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants