roles: add tls support #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleg-jukovec
requested review from
DifferentialOrange
and removed request for
DerekBum
themilchenko
force-pushed
the
themilchenko/gh-199-add-ssl-support-httpd-role
branch
2 times, most recently
from
42d35ed
to
3d573c0
Compare
themilchenko
force-pushed
the
themilchenko/gh-199-add-ssl-support-httpd-role
branch
from
3d573c0
to
b6724ad
Compare
oleg-jukovec
approved these changes
Nov 13, 2024
themilchenko
force-pushed
the
themilchenko/gh-199-add-ssl-support-httpd-role
branch
from
b6724ad
to
e52e6f0
Compare
Since we support TLS in this module, we need to add it into roles too. After the patch TLS params was added. It can be configurated like the following: ```yaml server_name: listen: "localhost:3013" ssl_key_file: "path/to/key/file" ssl_cert_file: "path/to/key/file" ssl_ca_file: "path/to/key/file" ssl_ciphers: "cipher1:cipher2" ssl_password: "password" ssl_password_file: "path/to/ssl/password" ``` Closes #199
It was a typo in `roles.httpd` paragraph - listen addresses was wrongly declared as a list in `roles_cfg` target. After the patch list's markers was deleted.
themilchenko
force-pushed
the
themilchenko/gh-199-add-ssl-support-httpd-role
branch
from
e52e6f0
to
bf6369e
Compare
DifferentialOrange
approved these changes
Nov 13, 2024
themilchenko
deleted the
themilchenko/gh-199-add-ssl-support-httpd-role
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we support TLS in this module, we need to add it into roles too.
After the patch TLS params was added. It can be configurated like the following:
Closes #199