Update ring requirement from 0.14.6 to 0.16.0

[dependabot-preview]

Updates the requirements on ring to permit the latest version.

Commits

• See full diff in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

---

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot ignore this [patch|minor|major] version will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it). To ignore the version in this PR you can just close it
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
• @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
• @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
• @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
• @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
• @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

• Update frequency (including time of day and day of week)
• Pull request limits (per update run and/or open at any time)
• Out-of-range updates (receive only lockfile updates, if desired)
• Security updates (receive only security updates, if desired)

Finally, you can contact us by mentioning @dependabot.

[djmitche]

From #35, Looks like this needs a newer stable rust..

[djmitche]

Needs even a bit more work:

error: Could not compile `hawk`.
warning: build failed, waiting for other jobs to finish...
error[E0599]: no method named `digest_algorithm` found for type `ring::hmac::Key` in the current scope
  --> src/crypto/ring.rs:21:38
   |
21 |         let mut mac = vec![0; self.0.digest_algorithm().output_len];
   |                                      ^^^^^^^^^^^^^^^^

error[E0599]: no method named `fill` found for type `fn(()) -> ring::rand::SystemRandom {ring::rand::SystemRandom}` in the current scope
  --> src/crypto/ring.rs:48:34
   |
48 |         ring::rand::SystemRandom.fill(output)?;
   |                                  ^^^^
   |
   = note: ring::rand::SystemRandom is a function, perhaps you wish to call it
   = note: the method `fill` exists but the following trait bounds were not satisfied:
           `fn(()) -> ring::rand::SystemRandom {ring::rand::SystemRandom} : ring::rand::SecureRandom`

error[E0277]: `?` couldn't convert the error to `crypto::CryptoError`
  --> src/crypto/ring.rs:57:59
   |
57 |         let k = hmac::SigningKey::new(algorithm.try_into()?, key);
   |                                                           ^ the trait `std::convert::From<std::convert::Infallible>` is not implemented for `crypto::CryptoError`
   |
   = help: the following implementations were found:
             <crypto::CryptoError as std::convert::From<ring::error::Unspecified>>
   = note: required by `std::convert::From::from`

error[E0277]: the trait bound `ring::hmac::Algorithm: std::convert::From<credentials::DigestAlgorithm>` is not satisfied
  --> src/crypto/ring.rs:57:49
   |
57 |         let k = hmac::SigningKey::new(algorithm.try_into()?, key);
   |                                                 ^^^^^^^^ the trait `std::convert::From<credentials::DigestAlgorithm>` is not implemented for `ring::hmac::Algorithm`
   |
   = note: required because of the requirements on the impl of `std::convert::Into<ring::hmac::Algorithm>` for `credentials::DigestAlgorithm`
   = note: required because of the requirements on the impl of `std::convert::TryFrom<credentials::DigestAlgorithm>` for `ring::hmac::Algorithm`
   = note: required because of the requirements on the impl of `std::convert::TryInto<ring::hmac::Algorithm>` for `credentials::DigestAlgorithm`

warning: unused import: `ring::rand::SecureRandom`
  --> src/crypto/ring.rs:47:13
   |
47 |         use ring::rand::SecureRandom;
   |             ^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: #[warn(unused_imports)] on by default

error: aborting due to 5 previous errors

[djmitche]

I'm interested in feedback on #38 too..

[eoger]

Looks good to me, thanks!

[eoger]

Do we still need the TryFrom impl bellow?

[djmitche]

Yes, both are used.

[eoger]

For completeness, why did we add this?

[djmitche]

The most accurate answer is "the compiler told me to". I tried looking through the ring commits to see what breaking changes had occurred, and 50 commits in I had no idea.

But more precisely, one of those try_from()?'s returns Result<, Infallible>, and this impl made the types check out in that case. If there's a better approach I'm all 👀 :)