Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create built-in matrix transforms to facilitate splitting tasks by arbitrary values #588

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

ahal
Copy link
Collaborator

@ahal ahal commented Oct 9, 2024

This was inspired by a comment someone made around how they much preferred Github Actions' matrix scheme to how you need to create purpose built transforms anytime you wanted to split a task by some set of values.

On reflection, I had to agree. I figured it wouldn't be terribly hard to implement a similar solution in Taskgraph.

@ahal ahal self-assigned this Oct 9, 2024
@ahal ahal force-pushed the matrix branch 4 times, most recently from 74d2a42 to 79e254b Compare October 9, 2024 19:16
@ahal ahal requested review from a team and bhearsum October 9, 2024 19:23
Copy link
Contributor

@bhearsum bhearsum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really fantastic overall! I"m leaving this unapproved for the moment because I'm interested in answers to some of the questions below.

docs/reference/transforms/matrix.rst Show resolved Hide resolved
docs/reference/transforms/matrix.rst Show resolved Hide resolved
docs/reference/transforms/matrix.rst Show resolved Hide resolved
docs/reference/transforms/matrix.rst Outdated Show resolved Hide resolved
docs/reference/transforms/matrix.rst Outdated Show resolved Hide resolved
docs/reference/transforms/matrix.rst Outdated Show resolved Hide resolved
src/taskgraph/transforms/matrix.py Show resolved Hide resolved
src/taskgraph/transforms/matrix.py Outdated Show resolved Hide resolved
Copy link
Contributor

@jcristau jcristau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@ahal ahal merged commit 431e051 into taskcluster:main Oct 17, 2024
14 checks passed
@ahal ahal deleted the matrix branch October 17, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants